Fix Tests Analytics #17
@@ -108,7 +108,7 @@ enum FirebaseGenerator {
|
|||||||
parameters: parameters
|
parameters: parameters
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
"""
|
"""
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -60,7 +60,7 @@ class AnalyticsDefinition {
|
|||||||
switch parameter.type {
|
switch parameter.type {
|
||||||
case .bool:
|
case .bool:
|
||||||
defaultValue = "\(parameter.defaultValue.lowercased())"
|
defaultValue = "\(parameter.defaultValue.lowercased())"
|
||||||
|
|
||||||
case .int, .double:
|
case .int, .double:
|
||||||
defaultValue = "\(parameter.defaultValue)"
|
defaultValue = "\(parameter.defaultValue)"
|
||||||
|
|
||||||
|
@@ -70,7 +70,7 @@ class AnalyticsFileParser {
|
|||||||
private static func getParameters(from parameters: [AnalyticsParameterDTO]) -> [AnalyticsParameter] {
|
private static func getParameters(from parameters: [AnalyticsParameterDTO]) -> [AnalyticsParameter] {
|
||||||
func verify(value: String?, for type: ParameterType) {
|
func verify(value: String?, for type: ParameterType) {
|
||||||
guard let value, value.isEmpty == false else { return }
|
guard let value, value.isEmpty == false else { return }
|
||||||
|
|
||||||
switch type {
|
switch type {
|
||||||
case .int:
|
case .int:
|
||||||
if Int(value) == nil {
|
if Int(value) == nil {
|
||||||
@@ -78,7 +78,7 @@ class AnalyticsFileParser {
|
|||||||
print(error.description)
|
print(error.description)
|
||||||
Analytics.exit(withError: error)
|
Analytics.exit(withError: error)
|
||||||
}
|
}
|
||||||
|
|
||||||
case .bool:
|
case .bool:
|
||||||
if Bool(value.lowercased()) == nil {
|
if Bool(value.lowercased()) == nil {
|
||||||
let error = AnalyticsError.invalidParameter("type of \(value) is not \(type)")
|
let error = AnalyticsError.invalidParameter("type of \(value) is not \(type)")
|
||||||
@@ -97,7 +97,7 @@ class AnalyticsFileParser {
|
|||||||
break
|
break
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
return parameters.map { dtoParameter in
|
return parameters.map { dtoParameter in
|
||||||
// Type
|
// Type
|
||||||
let type = dtoParameter.type.uppercasedFirst()
|
let type = dtoParameter.type.uppercasedFirst()
|
||||||
@@ -107,13 +107,13 @@ class AnalyticsFileParser {
|
|||||||
print(error.description)
|
print(error.description)
|
||||||
Analytics.exit(withError: error)
|
Analytics.exit(withError: error)
|
||||||
}
|
}
|
||||||
|
|
||||||
if dtoParameter.value != nil, dtoParameter.replaceIn != nil {
|
if dtoParameter.value != nil, dtoParameter.replaceIn != nil {
|
||||||
let error = AnalyticsError.invalidParameter("you can't set 'value' and 'replaceIn' for \(dtoParameter.name)")
|
let error = AnalyticsError.invalidParameter("you can't set 'value' and 'replaceIn' for \(dtoParameter.name)")
|
||||||
print(error.description)
|
print(error.description)
|
||||||
Analytics.exit(withError: error)
|
Analytics.exit(withError: error)
|
||||||
}
|
}
|
||||||
|
|
||||||
verify(value: dtoParameter.value, for: typeEnum)
|
verify(value: dtoParameter.value, for: typeEnum)
|
||||||
verify(value: dtoParameter.defaultValue, for: typeEnum)
|
verify(value: dtoParameter.defaultValue, for: typeEnum)
|
||||||
|
|
||||||
@@ -218,7 +218,7 @@ class AnalyticsFileParser {
|
|||||||
if let category = event.category {
|
if let category = event.category {
|
||||||
definition.category = category
|
definition.category = category
|
||||||
}
|
}
|
||||||
|
|
||||||
if let action = event.action {
|
if let action = event.action {
|
||||||
definition.action = action
|
definition.action = action
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user