Add Swiftlint

Jenkinsfile

@@ -1,6 +1,6 @@
 library "openiumpipeline"
 
-env.DEVELOPER_DIR="/Applications/Xcode-15.4.0.app/Contents/Developer"
+env.DEVELOPER_DIR="/Applications/Xcode-15.0.1.app/Contents/Developer"
 //env.SIMULATOR_DEVICE_TYPES="iPad--7th-generation-"
 env.IS_PACKAGE_SWIFT=1
 env.TARGETS_MACOS=1

Package.resolved

@@ -14,8 +14,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/krzyzanowskim/CryptoSwift.git",
       "state" : {
-        "revision" : "c9c3df6ab812de32bae61fc0cd1bf6d45170ebf0",
-        "version" : "1.8.2"
+        "revision" : "db51c407d3be4a051484a141bf0bff36c43d3b1e",
+        "version" : "1.8.0"
       }
     },
     {

README.md

@@ -81,7 +81,7 @@ swift run -c release ResgenSwift strings twine $FORCE_FLAG "./Twine/strings.txt"
 2. Input translations file (must be Twine formatted)
 3. `--langs`: langs to generate (string with space between each lang)
 4. `--default-lang`: default lang that will be in `Base.lproj`. It must be in `langs` as well
-5. `--extension-output-path`: path where to generate generated extension
+4. `--extension-output-path`: path where to generate generated extension
 
 ### Stringium (recommended)
 
@@ -93,7 +93,6 @@ swift run -c release ResgenSwift strings stringium $FORCE_FLAG "./Strings/string
  --extension-output-path "./Strings/Generated" \
  --extension-name "AppString" \
  --extension-suffix "GreatApp" \
- --xcStrings true
  --static-members true
 ```
 
@@ -106,7 +105,6 @@ swift run -c release ResgenSwift strings stringium $FORCE_FLAG "./Strings/string
 4. `--extension-output-path`: path where to generate generated extension
 5. `--extension-name` *(optional)* : name of class to add the extension
 6. `--extension-suffix` *(optional)* : additional text which is added to filename (ex: `AppString+GreatApp.swift`)
-6. `--xcStrings`*(optional)* : generate string catalog
 7. `--static-members` *(optional)*: generate static properties or not
 
 
@@ -135,71 +133,6 @@ swift run -c release ResgenSwift strings tags $FORCE_FLAG "./Tags/tags.txt" \
 
 > ⚠️ If extension name is not set or is `Tags`, it will generate the following typaloas  `typealias Tags = String`.
 
-
-## Analytics
-
-Analytics will generate all you need to analyze UX with Matomo or Firebase Analytics. Input files are formatted in YAML. This command will generate a manager for each target and an AnalyticsManager. This is this one you will need to use. And it will generate a method for all tags you have declared in the YAML file. Next, you will need to use the `configure()` method of AnalyticsManager and if you want to use matomo to set up the `siteId` and the `url` of the site.
-
-```sh
-swift run -c release ResgenSwift strings tags $FORCE_FLAG "./Tags/tags.txt" \
- --target "matomo firebase" \
- --extension-output-path "./Analytics/Generated" \
- --extension-name "AppAnalytics" \
- --extension-suffix "GreatApp" \
- --static-members true
-```
- 
- **Parameters**
-
-1. `-f`: force generation
-2. Input tags file (must be YAML formatted)
-3. `--target`: target with you will log UX
-4. `--extension-output-path`: path where to generate generated extension
-5. `--extension-name` *(optional)* : name of class to add the extension
-6. `--extension-suffix` *(optional)* : additional text which is added to filename (ex: `AppAnalytics+GreatApp.swift`)
-7. `--static-members` *(optional)*: generate static properties or not
-
-> ⚠️ If extension name is not set or is `Analytics`, it will generate the following typaloas  `typealias Analytics = String`.
-
-### YAML
-
-```
- - id: s1_def_one
-   name: s1 def one _TITLE_
-   path: s1_def_one/_TITLE_
-   action: Tap
-   category: User
-   tags: ios,droid
-   comments:
-   parameters:
-     - name: title
-       type: String
-       replaceIn: name,path
-```
-
-1. `id`: name of the method (method name will be composed of `log` + `Event|Screen` + `id`)
-2. `name`: name of the tag
-3. `path` *(optional with firebase)* : needed for matomo but not with firebase (log screen)
-4. `action` *(optional with firebase)* : needed for matomo but not with firebase (log event)
-5. `category` *(optional with firebase)* : needed for matomo but not with firebase (log event)
-6. `tags`: which platform target
-7. `comments` *(optional)*
-8. `parameters` *(optional)*
-
- **Parameters**
-
-You can use parameters in generate methods. 
-
-1. `name`: name of the parameter
-2. `type`: type of the parameter (Int, String, Bool, Double)
-3. `replaceIn` *(optional)*
-
-**Replace in**
-
-This is section is equivalent of `%s | %d | %f | %@`. You can put the content of the parameter in *name*, *path*, *action*, *category*.
-You need to put `_` + `NAME OF THE PARAMETER` + `_` in the target and which target you want in the value of `replaceIn`. (name need to be in uppercase)
-
-
 ## Images
 
 Images generator will generate images assets along with extensions to access those images easily.
@@ -225,7 +158,6 @@ swift run -c release ResgenSwift images $FORCE_FLAG "./Images/images.txt" \
 6. `--extension-suffix` *(optional)* : additional text which is added to filename (ex: `AppImage+GreatApp.swift`)
 7. `--static-members` *(optional)*: generate static properties or not
 
-> ⚠️ Svg images will be copied in the assets and rendered as "Original", however if those images are not rendered correctly you can force the png generation by adding the key word "png" like this: id arrow_back 15 ? png
 
 ## All at once
 

SampleFiles/Tags/Generated/Analytics+GenAllScript.swift

@@ -81,7 +81,7 @@ class MatomoAnalyticsManager: AnalyticsManagerProtocol {
 class FirebaseAnalyticsManager: AnalyticsManagerProtocol {
     func logScreen(name: String, path: String) {
         var parameters = [
-            AnalyticsParameterScreenName: name as NSObject
+            AnalyticsParameterScreenName: name
         ]
 
         Analytics.logEvent(
@@ -96,25 +96,19 @@ class FirebaseAnalyticsManager: AnalyticsManagerProtocol {
         category: String,
         params: [String: Any]?
     ) {
-        var parameters: [String:NSObject] = [
-            "action": action as NSObject,
-            "category": category as NSObject,
+        var parameters: [String:Any] = [
+            "action": action,
+            "category": category,
         ]
 
         if let supplementaryParameters = params {
-            for (newKey, newValue) in supplementaryParameters {
-                if parameters.contains(where: { (key: String, value: NSObject) in
-                    key == newKey
-                }) {
-                    continue
-                }
-                
-                parameters[newKey] = newValue as? NSObject
+            parameters.merge(supplementaryParameters) { (origin, new) -> Any in
+                return origin
             }
         }
         
         Analytics.logEvent(
-            name.replacingOccurrences(of: [" "], with: "_"),
+            name,
             parameters: parameters
         )
     }
@@ -175,22 +169,19 @@ class AnalyticsManager {
 
     // MARK: - section_one
 
-    func logScreenS1DefOne(title: String) {
+    func logScreenS1DefOne() {
         logScreen(
-            name: "s1 def one \(title)",
-            path: "s1_def_one/\(title)"
+            name: "s1 def one",
+            path: "s1_def_one/"
         )
     }
 
-    func logEventS1DefTwo(title: String, count: String) {
+    func logEventS1DefTwo() {
         logEvent(
             name: "s1 def two",
             action: "test",
             category: "test",
-            params: [
-                "title": title,
-				"count": count
-            ]
+            params: [:]
         )
     }
 

SampleFiles/Tags/sampleTags.yml

@@ -3,13 +3,9 @@ categories:
   - id: section_one
     screens:
       - id: s1_def_one
-        name: s1 def one _TITLE_
-        path: s1_def_one/_TITLE_
-        tags: ios,droid
-        parameters:
-          - name: title
-            type: String
-            replaceIn: name,path
+        name: s1 def one
+        path: s1_def_one/
+        tags: ios
               
     events:
       - id: s1_def_two
@@ -17,11 +13,6 @@ categories:
         action: test
         category: test
         tags: ios
-        parameters:
-          - name: title
-            type: String
-          - name: count
-            type: String
             
   - id: section_two
     screens:

SampleFiles/genAllRessources.sh

@@ -52,19 +52,19 @@ FORCE_FLAG="$1"
 
 #echo "\n-------------------------\n"
 
-# Analytics
-swift run -c release ResgenSwift analytics $FORCE_FLAG "./Tags/sampleTags.yml" \
- --target "matomo firebase" \
- --extension-output-path "./Tags/Generated" \
- --extension-name "Analytics" \
- --extension-suffix "GenAllScript"
+## Analytics
+#swift run -c release ResgenSwift analytics $FORCE_FLAG "./Tags/sampleTags.yml" \
+# --target "matomo firebase" \
+# --extension-output-path "./Tags/Generated" \
+# --extension-name "Analytics" \
+# --extension-suffix "GenAllScript"
 
 #echo "\n-------------------------\n"
 #
-## Images
-#swift run -c release ResgenSwift images $FORCE_FLAG "./Images/sampleImages.txt" \
-# --xcassets-path "./Images/imagium.xcassets" \
-# --extension-output-path "./Images/Generated" \
-# --extension-name "ImageYolo" \
-# --extension-name-ui-kit "UIImageYolo" \
-# --extension-suffix "GenAllScript"
+# Images
+swift run -c release ResgenSwift images $FORCE_FLAG "./Images/sampleImages.txt" \
+ --xcassets-path "./Images/imagium.xcassets" \
+ --extension-output-path "./Images/Generated" \
+ --extension-name "ImageYolo" \
+ --extension-name-ui-kit "UIImageYolo" \
+ --extension-suffix "GenAllScript"

Sources/ResgenSwift/Analytics/Analytics.swift

@@ -32,10 +32,6 @@ struct Analytics: ParsableCommand {
     mutating func run() {
         print("[\(Self.toolName)] Starting analytics generation")
         print("[\(Self.toolName)] Will use inputFile \(options.inputFile) to generate analytics for target: \(options.target)")
-
-        // Check requirements
-        guard checkRequirements() else { return }
-
         print("[\(Self.toolName)] Will generate analytics")
         
         // Check requirements
@@ -67,12 +63,6 @@ struct Analytics: ParsableCommand {
             Analytics.exit(withError: error)
         }
         
-        guard TrackerType.hasValidTarget(in: options.target) else {
-            let error = AnalyticsError.noValidTracker(options.target)
-            print(error.description)
-            Analytics.exit(withError: error)
-        }
-
         // Check if needed to regenerate
         guard GeneratorChecker.shouldGenerate(force: options.forceGeneration,
                                               inputFilePath: options.inputFile,
@@ -84,3 +74,19 @@ struct Analytics: ParsableCommand {
         return true
     }
 }
+
+extension Analytics {
+    enum TargetType: CaseIterable {
+        case matomo
+        case firebase
+        
+        var value: String {
+            switch self {
+            case .matomo:
+                "matomo"
+            case .firebase:
+                "firebase"
+            }
+        }
+    }
+}

Sources/ResgenSwift/Analytics/AnalyticsError.swift

@@ -8,18 +8,14 @@
 import Foundation
 
 enum AnalyticsError: Error {
-    case noValidTracker(String)
     case fileNotExists(String)
     case missingElement(String)
     case invalidParameter(String)
-    case parseFailed(String)
+    
     case writeFile(String, String)
     
     var description: String {
         switch self {
-        case .noValidTracker(let inputTargets):
-            return "error: [\(Analytics.toolName)] '\(inputTargets)' ne contient aucun tracker valid"
-
         case .fileNotExists(let filename):
             return "error: [\(Analytics.toolName)] File \(filename) does not exists "
             
@@ -29,9 +25,6 @@ enum AnalyticsError: Error {
         case .invalidParameter(let reason):
             return "error: [\(Analytics.toolName)] Invalid parameter \(reason)"
             
-        case .parseFailed(let baseError):
-            return "error: [\(Analytics.toolName)] Parse input file failed: \(baseError)"
-
         case .writeFile(let subErrorDescription, let filename):
             return "error: [\(Analytics.toolName)] An error occured while writing content to \(filename): \(subErrorDescription)"
         }

Sources/ResgenSwift/Analytics/Generator/AnalyticsGenerator.swift

@@ -10,13 +10,13 @@ import ToolCore
 import CoreVideo
 
 class AnalyticsGenerator {
-    static var targets: [TrackerType] = []
+    static var targets: [Analytics.TargetType] = []
     
     static func writeExtensionFiles(sections: [AnalyticsCategory], target: String, tags: [String], staticVar: Bool, extensionName: String, extensionFilePath: String) {
         // Get target type from enum
         let targetsString: [String] = target.components(separatedBy: " ")
                 
-        TrackerType.allCases.forEach { enumTarget in
+        Analytics.TargetType.allCases.forEach { enumTarget in
             if targetsString.contains(enumTarget.value) {
                 targets.append(enumTarget)
             }
@@ -32,7 +32,7 @@ class AnalyticsGenerator {
         let extensionFilePathURL = URL(fileURLWithPath: extensionFilePath)
         do {
             try extensionFileContent.write(to: extensionFilePathURL, atomically: false, encoding: .utf8)
-        } catch let error {
+        } catch (let error) {
             let error = AnalyticsError.writeFile(extensionFilePath, error.localizedDescription)
             print(error.description)
             Analytics.exit(withError: error)
@@ -58,7 +58,7 @@ class AnalyticsGenerator {
         
         \(Self.getImport())
         
-        \(Self.getAnalyticsProtocol())
+        \(Self.getAnalytics())
         // MARK: - Manager
         
         class AnalyticsManager {
@@ -91,10 +91,10 @@ class AnalyticsGenerator {
     private static func getImport() -> String {
         var result: [String] = []
         
-        if targets.contains(TrackerType.matomo) {
+        if targets.contains(Analytics.TargetType.matomo) {
             result.append("import MatomoTracker")
         }
-        if targets.contains(TrackerType.firebase) {
+        if targets.contains(Analytics.TargetType.firebase) {
             result.append("import FirebaseAnalytics")
         }
         
@@ -136,13 +136,13 @@ class AnalyticsGenerator {
         var content: [String] = []
         let footer = "    }"
         
-        if targets.contains(TrackerType.matomo) {
+        if targets.contains(Analytics.TargetType.matomo) {
             header = "func configure(siteId: String, url: String) {"
-        } else if targets.contains(TrackerType.firebase) {
+        } else if targets.contains(Analytics.TargetType.firebase) {
             header = "func configure() {"
         }
         
-        if targets.contains(TrackerType.matomo) {
+        if targets.contains(Analytics.TargetType.matomo) {
             content.append("""
                     managers.append(
                         MatomoAnalyticsManager(
@@ -152,7 +152,7 @@ class AnalyticsGenerator {
                     )
             """)
         }
-        if targets.contains(TrackerType.firebase) {
+        if targets.contains(Analytics.TargetType.firebase) {
             content.append("        managers.append(FirebaseAnalyticsManager())")
         }
         
@@ -164,7 +164,7 @@ class AnalyticsGenerator {
             .joined(separator: "\n")
     }
     
-    private static func getAnalyticsProtocol() -> String {
+    private static func getAnalytics() -> String {
         let proto = """
         // MARK: - Protocol
         
@@ -182,12 +182,12 @@ class AnalyticsGenerator {
         
         var result: [String] = [proto]
         
-        if targets.contains(TrackerType.matomo) {
-            result.append(MatomoGenerator.service)
+        if targets.contains(Analytics.TargetType.matomo) {
+            result.append(MatomoGenerator.service.content)
         }
         
-        if targets.contains(TrackerType.firebase) {
-            result.append(FirebaseGenerator.service)
+        if targets.contains(Analytics.TargetType.firebase) {
+            result.append(FirebaseGenerator.service.content)
         }
         
         return result.joined(separator: "\n")

Sources/ResgenSwift/Analytics/Generator/FirebaseGenerator.swift

@@ -8,20 +8,19 @@
 import Foundation
 
 enum FirebaseGenerator {
+    case service
     
-    static var service: String {
+    var content: String {
         [
-            FirebaseGenerator.header,
-            FirebaseGenerator.logScreen,
-            FirebaseGenerator.logEvent,
-            FirebaseGenerator.footer
+            FirebaseGenerator.service.header,
+            FirebaseGenerator.service.logScreen,
+            FirebaseGenerator.service.logEvent,
+            FirebaseGenerator.service.footer
         ]
             .joined(separator: "\n")
     }
     
-    // MARK: - Private vars
-
-    private static var header: String {
+    private var header: String {
         """
         // MARK: - Firebase
 
@@ -29,11 +28,11 @@ enum FirebaseGenerator {
         """
     }
     
-    private static var logScreen: String {
+    private var logScreen: String {
         """
             func logScreen(name: String, path: String) {
                 var parameters = [
-                    AnalyticsParameterScreenName: name as NSObject
+                    AnalyticsParameterScreenName: name
                 ]
         
                 Analytics.logEvent(
@@ -45,7 +44,7 @@ enum FirebaseGenerator {
         """
     }
     
-    private static var logEvent: String {
+    private var logEvent: String {
         """
             func logEvent(
                 name: String,
@@ -53,32 +52,26 @@ enum FirebaseGenerator {
                 category: String,
                 params: [String: Any]?
             ) {
-                var parameters: [String:NSObject] = [
-                    "action": action as NSObject,
-                    "category": category as NSObject,
+                var parameters: [String:Any] = [
+                    "action": action,
+                    "category": category,
                 ]
         
                 if let supplementaryParameters = params {
-                    for (newKey, newValue) in supplementaryParameters {
-                        if parameters.contains(where: { (key: String, value: NSObject) in
-                            key == newKey
-                        }) {
-                            continue
-                        }
-                        
-                        parameters[newKey] = newValue as? NSObject
+                    parameters.merge(supplementaryParameters) { (origin, new) -> Any in
+                        return origin
                     }
                 }
                 
                 Analytics.logEvent(
-                    name.replacingOccurrences(of: [" "], with: "_"),
+                    name,
                     parameters: parameters
                 )
             }
         """
     }
     
-    private static var footer: String {
+    private var footer: String {
         """
         }
         

Sources/ResgenSwift/Analytics/Generator/MatomoGenerator.swift

@@ -8,21 +8,20 @@
 import Foundation
 
 enum MatomoGenerator {
+    case service
     
-    static var service: String {
+    var content: String {
         [
-            MatomoGenerator.header,
-            MatomoGenerator.setup,
-            MatomoGenerator.logScreen,
-            MatomoGenerator.logEvent,
-            MatomoGenerator.footer
+            MatomoGenerator.service.header,
+            MatomoGenerator.service.setup,
+            MatomoGenerator.service.logScreen,
+            MatomoGenerator.service.logEvent,
+            MatomoGenerator.service.footer
         ]
             .joined(separator: "\n")
     }
     
-    // MARK: - Private vars
-
-    private static var header: String {
+    private var header: String {
         """
         // MARK: - Matomo
 
@@ -35,7 +34,7 @@ enum MatomoGenerator {
         """
     }
     
-    private static var setup: String {
+    private var setup: String {
         """
             // MARK: - Init
         
@@ -64,7 +63,7 @@ enum MatomoGenerator {
         """
     }
     
-    private static var logScreen: String {
+    private var logScreen: String {
         """
             func logScreen(name: String, path: String) {
                 guard !tracker.isOptedOut else { return }
@@ -80,7 +79,7 @@ enum MatomoGenerator {
         """
     }
     
-    private static var logEvent: String {
+    private var logEvent: String {
         """
             func logEvent(
                 name: String,
@@ -101,7 +100,7 @@ enum MatomoGenerator {
         """
     }
     
-    private static var footer: String {
+    private var footer: String {
         """
         }
         

Sources/ResgenSwift/Analytics/Model/AnalyticsCategory.swift

@@ -11,14 +11,10 @@ class AnalyticsCategory {
     let id: String // OnBoarding
     var definitions = [AnalyticsDefinition]()
     
-    // MARK: - Init
-
     init(id: String) {
         self.id = id
     }
     
-    // MARK: - Methods
-
     func hasOneOrMoreMatchingTags(tags: [String]) -> Bool {
         let allTags = definitions.flatMap { $0.tags }
         let allTagsSet = Set(allTags)

Sources/ResgenSwift/Analytics/Model/AnalyticsDefinition.swift

@@ -6,7 +6,6 @@
 //
 
 import Foundation
-import ToolCore
 
 class AnalyticsDefinition {
     let id: String
@@ -19,16 +18,12 @@ class AnalyticsDefinition {
     var parameters: [AnalyticsParameter] = []
     var type: TagType
     
-    // MARK: - Init
-
     init(id: String, name: String, type: TagType) {
         self.id = id
         self.name = name
         self.type = type
     }
     
-    // MARK: - Methods
-
     func hasOneOrMoreMatchingTags(inputTags: [String]) -> Bool {
         if Set(inputTags).isDisjoint(with: tags) {
             return false
@@ -36,7 +31,7 @@ class AnalyticsDefinition {
         return true
     }
     
-    // MARK: - Private Methods
+    // MARK: - Methods
     
     private func getFuncName() -> String {
         var pascalCaseTitle: String = ""
@@ -155,3 +150,27 @@ class AnalyticsDefinition {
         """
     }
 }
+
+extension AnalyticsDefinition {
+    enum TagType {
+        case screen
+        case event
+    }
+}
+
+extension String {
+    func replacingFirstOccurrence(of: String, with: String) -> Self {
+        if let range = self.range(of: of) {
+            let tmp = self.replacingOccurrences(
+                of: of,
+                with: with,
+                options: .literal,
+                range: range
+            )
+
+            return tmp
+        }
+        
+        return self
+    }
+}

Sources/ResgenSwift/Analytics/Model/AnalyticsFile.swift

@@ -17,7 +17,9 @@ struct AnalyticsCategoryDTO: Codable {
     var events: [AnalyticsDefinitionEventDTO]?
 }
 
-struct AnalyticsDefinitionScreenDTO: Codable {
+protocol AnalyticsDefinitionDTO: Codable {}
+
+struct AnalyticsDefinitionScreenDTO: AnalyticsDefinitionDTO {
     var id: String
     var name: String
     var tags: String
@@ -27,7 +29,7 @@ struct AnalyticsDefinitionScreenDTO: Codable {
     var path: String?
 }
 
-struct AnalyticsDefinitionEventDTO: Codable {
+struct AnalyticsDefinitionEventDTO: AnalyticsDefinitionDTO {
     var id: String
     var name: String
     var tags: String

Sources/ResgenSwift/Analytics/Model/AnalyticsParameter.swift

@@ -12,8 +12,6 @@ class AnalyticsParameter {
     var type: String
     var replaceIn: [String] = []
     
-    // MARK: - Init
-    
     init(name: String, type: String) {
         self.name = name
         self.type = type

Sources/ResgenSwift/Analytics/Model/TagType.swift

@@ -1,16 +0,0 @@
-//
-//  TagType.swift
-//  
-//
-//  Created by Thibaut Schmitt on 08/12/2023.
-//
-
-import Foundation
-
-extension AnalyticsDefinition {
-    
-    enum TagType {
-        case screen
-        case event
-    }
-}

Sources/ResgenSwift/Analytics/Model/TargetType.swift

@@ -1,29 +0,0 @@
-//
-//  TargetType.swift
-//  
-//
-//  Created by Thibaut Schmitt on 08/12/2023.
-//
-
-import Foundation
-
-enum TrackerType: CaseIterable {
-    case matomo
-    case firebase
-
-    var value: String {
-        switch self {
-        case .matomo:
-            "matomo"
-        case .firebase:
-            "firebase"
-        }
-    }
-
-    static func hasValidTarget(in targets: String) -> Bool {
-        for tracker in Self.allCases where targets.contains(tracker.value) {
-            return true
-        }
-        return false
-    }
-}

Sources/ResgenSwift/Analytics/Parser/AnalyticsFileParser.swift

@@ -15,25 +15,24 @@ class AnalyticsFileParser {
     private static func parseYaml() -> AnalyticsFile {
         guard let data = FileManager().contents(atPath: inputFile) else {
             let error = AnalyticsError.fileNotExists(inputFile)
-            print(error.description)
             Analytics.exit(withError: error)
         }
         
         do {
             let tagFile = try YAMLDecoder().decode(AnalyticsFile.self, from: data)
             return tagFile
-        } catch {
-            let error = AnalyticsError.parseFailed(error.localizedDescription)
-            print(error.description)
+        } catch let error {
             Analytics.exit(withError: error)
         }
     }
     
-    private static func getParameters(from parameters: [AnalyticsParameterDTO]) -> [AnalyticsParameter] {
-        parameters.map { dtoParameter in
+    private static func getParameters(fromData data: [AnalyticsParameterDTO]) -> [AnalyticsParameter] {
+        var parameters: [AnalyticsParameter] = []
+        
+        data.forEach { value in
             // Type
             
-            let type = dtoParameter.type.uppercasedFirst()
+            let type = value.type.uppercasedFirst()
             
             guard 
                 type == "String" ||
@@ -41,22 +40,20 @@ class AnalyticsFileParser {
                 type == "Double" ||
                 type == "Bool"
             else {
-                let error = AnalyticsError.invalidParameter("type of \(dtoParameter.name)")
-                print(error.description)
+                let error = AnalyticsError.invalidParameter("type of \(value.name)")
                 Analytics.exit(withError: error)
             }
             
-            let parameter = AnalyticsParameter(
-                name: dtoParameter.name,
-                type: type
-            )
+            let parameter: AnalyticsParameter = AnalyticsParameter(name: value.name, type: type)
             
-            if let replaceIn = dtoParameter.replaceIn {
+            if let replaceIn = value.replaceIn {
                 parameter.replaceIn = replaceIn.components(separatedBy: ",")
             }
             
-            return parameter
+            parameters.append(parameter)
         }
+        
+        return parameters
     }
 
     private static func getTagDefinition(
@@ -67,24 +64,24 @@ class AnalyticsFileParser {
         comments: String?,
         parameters: [AnalyticsParameterDTO]?
     ) -> AnalyticsDefinition {
-        let definition = AnalyticsDefinition(id: id, name: name, type: type)
-        definition.tags = tags
-            .components(separatedBy: ",")
-            .map { $0.removeLeadingTrailingWhitespace() }
+        let definition: AnalyticsDefinition = AnalyticsDefinition(id: id, name: name, type: type)
+        definition.tags = tags.components(separatedBy: ",")
         
         if let comments = comments {
             definition.comments = comments
         }
         
         if let parameters = parameters {
-            definition.parameters = Self.getParameters(from: parameters)
+            definition.parameters = Self.getParameters(fromData: parameters)
         }
         
         return definition
     }
     
-    private static func getTagDefinitionScreen(from screens: [AnalyticsDefinitionScreenDTO]) -> [AnalyticsDefinition] {
-        screens.map { screen in
+    private static func getTagDefinitionScreen(fromData screens: [AnalyticsDefinitionScreenDTO]) -> [AnalyticsDefinition] {
+        var definitions: [AnalyticsDefinition] = []
+            
+        for screen in screens {
             let definition: AnalyticsDefinition = Self.getTagDefinition(
                 id: screen.id,
                 name: screen.name,
@@ -94,24 +91,27 @@ class AnalyticsFileParser {
                 parameters: screen.parameters
             )
             
-            if target.contains(TrackerType.matomo.value) {
+            if target.contains(Analytics.TargetType.matomo.value) {
                 // Path
                 
                 guard let path = screen.path else {
                     let error = AnalyticsError.missingElement("screen path")
-                    print(error.description)
                     Analytics.exit(withError: error)
                 }
 
                 definition.path = path
             }
             
-            return definition
-        }
+            definitions.append(definition)
         }
         
-    private static func getTagDefinitionEvent(from events: [AnalyticsDefinitionEventDTO]) -> [AnalyticsDefinition] {
-        events.map { event in
+        return definitions
+    }
+    
+    private static func getTagDefinitionEvent(fromData events: [AnalyticsDefinitionEventDTO]) -> [AnalyticsDefinition] {
+        var definitions: [AnalyticsDefinition] = []
+            
+        for event in events {
             let definition: AnalyticsDefinition = Self.getTagDefinition(
                 id: event.id,
                 name: event.name,
@@ -121,58 +121,53 @@ class AnalyticsFileParser {
                 parameters: event.parameters
             )
             
-            if target.contains(TrackerType.matomo.value) {
+            if target.contains(Analytics.TargetType.matomo.value) {
                 // Category
+                
                 guard let category = event.category else {
                     let error = AnalyticsError.missingElement("event category")
-                    print(error.description)
                     Analytics.exit(withError: error)
                 }
                 
                 definition.category = category
                 
                 // Action
+                
                 guard let action = event.action else {
                     let error = AnalyticsError.missingElement("event action")
-                    print(error.description)
                     Analytics.exit(withError: error)
                 }
                 
                 definition.action = action
             }
             
-            return definition
+            definitions.append(definition)
         }
+        
+        return definitions
     }
     
     static func parse(_ inputFile: String, target: String) -> [AnalyticsCategory] {
         self.inputFile = inputFile
         self.target = target
         
-        let tagFile = Self.parseYaml()
+        let tagFile: AnalyticsFile = Self.parseYaml()
+        var sections: [AnalyticsCategory] = []
         
-        return tagFile
-            .categories
-            .map { categorie in
+        tagFile.categories.forEach { categorie in
             let section: AnalyticsCategory = AnalyticsCategory(id: categorie.id)
             
             if let screens = categorie.screens {
-                    section
-                        .definitions
-                        .append(
-                            contentsOf: Self.getTagDefinitionScreen(from: screens)
-                        )
+                section.definitions.append(contentsOf: Self.getTagDefinitionScreen(fromData: screens))
             }
             
             if let events = categorie.events {
-                    section
-                        .definitions
-                        .append(
-                        contentsOf: Self.getTagDefinitionEvent(from: events)
-                    )
+                section.definitions.append(contentsOf: Self.getTagDefinitionEvent(fromData: events))
             }
             
-                return section
-            }
+            sections.append(section)
+        }
+        
+        return sections
     }
 }

Sources/ResgenSwift/Generate/GenerateError.swift

@@ -9,7 +9,7 @@ import Foundation
 
 enum GenerateError: Error {
     case fileNotExists(String)
-    case invalidConfigurationFile(String, String)
+    case invalidConfigurationFile(String)
     case commandError([String], String)
     case writeFile(String, String)
     
@@ -18,8 +18,8 @@ enum GenerateError: Error {
         case .fileNotExists(let filename):
             return "error: [\(Generate.toolName)] File \(filename) does not exists"
     
-        case .invalidConfigurationFile(let filename, let underneathErrorDescription):
-            return "error: [\(Generate.toolName)] File \(filename) is not a valid configuration file. Underneath error: \(underneathErrorDescription)"
+        case .invalidConfigurationFile(let filename):
+            return "error: [\(Generate.toolName)] File \(filename) is not a valid configuration file"
             
         case .commandError(let command, let terminationStatus):
             let readableCommand = command

Sources/ResgenSwift/Generate/Model/ConfigurationFile.swift

@@ -269,7 +269,6 @@ struct StringsConfiguration: Codable, CustomDebugStringConvertible {
     let extensionName: String?
     let extensionSuffix: String?
     private let staticMembers: Bool?
-    private let xcStrings: Bool?
     
     var staticMembersOptions: Bool {
         if let staticMembers = staticMembers {
@@ -278,13 +277,6 @@ struct StringsConfiguration: Codable, CustomDebugStringConvertible {
         return false
     }
     
-    var xcStringsOptions: Bool {
-        if let xcStrings = xcStrings {
-            return xcStrings
-        }
-        return false
-    }
-
     internal init(inputFile: String,
                   outputPath: String,
                   langs: String,
@@ -292,8 +284,7 @@ struct StringsConfiguration: Codable, CustomDebugStringConvertible {
                   extensionOutputPath: String,
                   extensionName: String?,
                   extensionSuffix: String?,
-                  staticMembers: Bool?,
-                  xcStrings: Bool?) {
+                  staticMembers: Bool?) {
         self.inputFile = inputFile
         self.outputPath = outputPath
         self.langs = langs
@@ -302,7 +293,6 @@ struct StringsConfiguration: Codable, CustomDebugStringConvertible {
         self.extensionName = extensionName
         self.extensionSuffix = extensionSuffix
         self.staticMembers = staticMembers
-        self.xcStrings = xcStrings
     }
     
     var debugDescription: String {

Sources/ResgenSwift/Generate/Parser/ConfigurationFileParser.swift

@@ -16,15 +16,12 @@ class ConfigurationFileParser {
             Generate.exit(withError: error)
         }
         
-        do {
-            return try YAMLDecoder().decode(ConfigurationFile.self, from: data)
-        } catch {
-            let error = GenerateError.invalidConfigurationFile(
-                configurationFile,
-                error.localizedDescription.description
-            )
+        guard let configuration = try? YAMLDecoder().decode(ConfigurationFile.self, from: data) else {
+            let error = GenerateError.invalidConfigurationFile(configurationFile)
             print(error.description)
             Generate.exit(withError: error)
         }
+        
+        return configuration
     }
 }

Sources/ResgenSwift/Generate/Runnable/StringsConfiguration+Runnable.swift

@@ -26,9 +26,7 @@ extension StringsConfiguration: Runnable {
             "--extension-output-path",
             extensionOutputPath.prependIfRelativePath(projectDirectory),
             "--static-members",
-            "\(staticMembersOptions)",
-            "--xc-strings",
-            "\(xcStringsOptions)"
+            "\(staticMembersOptions)"
         ]
         
         if let extensionName = extensionName {

Sources/ResgenSwift/Images/Generator/XcassetsGenerator.swift

@@ -8,13 +8,10 @@
 import Foundation
 import ToolCore
 
-enum OutputImageExtension: String {
-    case png
-    case svg
-}
-
 class XcassetsGenerator {
     
+    static let outputImageExtension = "png"
+    
     let forceGeneration: Bool
     
     // MARK: - Init
@@ -63,20 +60,13 @@ class XcassetsGenerator {
             generatedAssetsPaths.append(imagesetName)
             
             // Generate output images path
-            let output1x = "\(imagesetPath)/\(parsedImage.name).\(OutputImageExtension.png.rawValue)"
-            let output2x = "\(imagesetPath)/\(parsedImage.name)@2x.\(OutputImageExtension.png.rawValue)"
-            let output3x = "\(imagesetPath)/\(parsedImage.name)@3x.\(OutputImageExtension.png.rawValue)"
+            let output1x = "\(imagesetPath)/\(parsedImage.name).\(XcassetsGenerator.outputImageExtension)"
+            let output2x = "\(imagesetPath)/\(parsedImage.name)@2x.\(XcassetsGenerator.outputImageExtension)"
+            let output3x = "\(imagesetPath)/\(parsedImage.name)@3x.\(XcassetsGenerator.outputImageExtension)"
             
             // Check if we need to convert image
-
-            var needToGenerateForSvg = false
-
-            if imageData.ext == "svg" && !parsedImage.imageExtensions.contains(.png) {
-                needToGenerateForSvg = true
-            }
-
-            guard self.shouldGenerate(inputImagePath: imageData.path, xcassetImagePath: output1x, needToGenerateForSvg: needToGenerateForSvg) else {
-                print("\(parsedImage.name) -> Not regenerating")
+            guard self.shouldGenerate(inputImagePath: imageData.path, xcassetImagePath: output1x) else {
+                //print("\(parsedImage.name) -> Not regenerating")
                 return
             }
             
@@ -90,22 +80,11 @@ class XcassetsGenerator {
                     print(error.description)
                     Images.exit(withError: error)
                 }
-            } else {
-                do {
-                    let documentsDirectory = try fileManager.contentsOfDirectory(atPath: imagesetPath)
-                    for filePath in documentsDirectory {
-                        try fileManager.removeItem(atPath: "\(imagesetPath)/\(filePath)")
-                    }
-                } catch {
-                    print("Error deleting previous assets")
-                }
             }
             
+            // Convert image
             let convertArguments = parsedImage.convertArguments
-
             if imageData.ext == "svg" {
-                if parsedImage.imageExtensions.contains(.png) {
-
                 // /usr/local/bin/rsvg-convert path/to/image.png -w 200 -h 300 -o path/to/output.png
                 // /usr/local/bin/rsvg-convert path/to/image.png -w 200 -o path/to/output.png
                 // /usr/local/bin/rsvg-convert path/to/image.png -h 300 -o path/to/output.png
@@ -124,21 +103,6 @@ class XcassetsGenerator {
                 Shell.shell(command1x)
                 Shell.shell(command2x)
                 Shell.shell(command3x)
-
-                } else {
-
-                    let output = "\(imagesetPath)/\(parsedImage.name).\(OutputImageExtension.svg.rawValue)"
-                    let tempURL = URL(fileURLWithPath: output)
-
-                    do {
-                        if FileManager.default.fileExists(atPath: tempURL.path) {
-                            try FileManager.default.removeItem(atPath: tempURL.path)
-                        }
-                        try FileManager.default.copyItem(atPath: imageData.path, toPath: tempURL.path)
-                    } catch {
-                        print(error.localizedDescription)
-                    }
-                }
             } else {
                 // convert path/to/image.png -resize 200x300 path/to/output.png
                 // convert path/to/image.png -resize 200x path/to/output.png
@@ -155,7 +119,7 @@ class XcassetsGenerator {
             }
             
             // Write Content.json
-            guard let imagesetContentJson = parsedImage.generateContentJson(isVector: imageData.ext == "svg") else { return }
+            let imagesetContentJson = parsedImage.contentJson
             let contentJsonFilePath = "\(imagesetPath)/Contents.json"
             
             let contentJsonFilePathURL = URL(fileURLWithPath: contentJsonFilePath)
@@ -197,8 +161,8 @@ class XcassetsGenerator {
     
     // MARK: - Helpers: bypass generation
     
-    private func shouldGenerate(inputImagePath: String, xcassetImagePath: String, needToGenerateForSvg: Bool) -> Bool {
-        if forceGeneration || needToGenerateForSvg {
+    private func shouldGenerate(inputImagePath: String, xcassetImagePath: String) -> Bool {
+        if forceGeneration {
             return true
         }
         

Sources/ResgenSwift/Images/Model/ImageContent.swift

@@ -1,76 +0,0 @@
-//
-//  ImageContent.swift
-//
-//
-//  Created by Quentin Bandera on 19/04/2024.
-//
-
-import Foundation
-
-enum TemplateRenderingIntent: String, Codable {
-    case template
-    case original
-}
-
-struct AssetContent: Codable, Equatable {
-    let images: [AssetImageDescription]
-    let info: AssetInfo
-    let properties: AssetProperties?
-
-    init(
-        images: [AssetImageDescription],
-        info: AssetInfo,
-        properties: AssetProperties? = nil
-    ) {
-        self.images = images
-        self.info = info
-        self.properties = properties
-    }
-
-    static func == (lhs: AssetContent, rhs: AssetContent) -> Bool {
-        guard lhs.images.count == rhs.images.count else { return false }
-        let lhsImages = lhs.images.sorted(by: { $0.filename < $1.filename })
-        let rhsImages = rhs.images.sorted(by: { $0.filename < $1.filename })
-
-        return lhsImages == rhsImages
-    }
-}
-
-struct AssetImageDescription: Codable, Equatable {
-    let idiom: String
-    let scale: String?
-    let filename: String
-
-    init(
-        idiom: String,
-        scale: String? = nil,
-        filename: String
-    ) {
-        self.idiom = idiom
-        self.scale = scale
-        self.filename = filename
-    }
-}
-
-struct AssetInfo: Codable, Equatable {
-    let version: Int
-    let author: String
-}
-
-struct AssetProperties: Codable, Equatable {
-    let preservesVectorRepresentation: Bool
-    let templateRenderingIntent: TemplateRenderingIntent?
-
-    init(
-        preservesVectorRepresentation: Bool,
-        templateRenderingIntent: TemplateRenderingIntent? = nil
-    ) {
-        self.preservesVectorRepresentation = preservesVectorRepresentation
-        self.templateRenderingIntent = templateRenderingIntent
-    }
-
-    enum CodingKeys: String, CodingKey {
-        case preservesVectorRepresentation = "preserves-vector-representation"
-        case templateRenderingIntent = "template-rendering-intent"
-    }
-}

Sources/ResgenSwift/Images/Model/ParsedImage.swift

@@ -7,30 +7,11 @@
 
 import Foundation
 
-enum ImageExtension: String {
-    case png
-}
-
 struct ParsedImage {
     let name: String
     let tags: String
     let width: Int
     let height: Int
-    let imageExtensions: [ImageExtension]
-
-    init(
-        name: String,
-        tags: String,
-        width: Int,
-        height: Int,
-        imageExtensions: [ImageExtension] = []
-    ) {
-        self.name = name
-        self.tags = tags
-        self.width = width
-        self.height = height
-        self.imageExtensions = imageExtensions
-    }
     
     // MARK: - Convert
     
@@ -61,68 +42,33 @@ struct ParsedImage {
     
     // MARK: - Assets
     
-    func generateContentJson(isVector: Bool) -> String? {
-        let encoder = JSONEncoder()
-        encoder.outputFormatting = .prettyPrinted
-
-        let imageContent = generateImageContent(isVector: isVector)
-
-        guard let data = try? encoder.encode(imageContent) else {
-            let error = ImagesError.writeFile("Contents.json", "Error encoding json file")
-            print(error.description)
-            Images.exit(withError: error)
+    var contentJson: String {
+        """
+        {
+          "images" : [
+            {
+              "idiom" : "universal",
+              "scale" : "1x",
+              "filename" : "\(name).\(XcassetsGenerator.outputImageExtension)"
+            },
+            {
+              "idiom" : "universal",
+              "scale" : "2x",
+              "filename" : "\(name)@2x.\(XcassetsGenerator.outputImageExtension)"
+            },
+            {
+              "idiom" : "universal",
+              "scale" : "3x",
+              "filename" : "\(name)@3x.\(XcassetsGenerator.outputImageExtension)"
             }
-
-        return String(data: data, encoding: .utf8)
-    }
-
-    func generateImageContent(isVector: Bool) -> AssetContent {
-
-        if !imageExtensions.contains(.png) && isVector {
-            //Generate svg
-            return AssetContent(
-                images: [
-                    AssetImageDescription(
-                        idiom: "universal",
-                        filename: "\(name).\(OutputImageExtension.svg.rawValue)"
-                    )
           ],
-                info: AssetInfo(
-                    version: 1,
-                    author: "ResgenSwift-Imagium"
-                ),
-                properties: AssetProperties(
-                    preservesVectorRepresentation: true,
-                    templateRenderingIntent: .original
-                )
-            )
-        } else {
-            //Generate png
-            return AssetContent(
-                images: [
-                    AssetImageDescription(
-                        idiom: "universal",
-                        scale: "1x",
-                        filename: "\(name).\(OutputImageExtension.png.rawValue)"
-                    ),
-                    AssetImageDescription(
-                        idiom: "universal",
-                        scale: "2x",
-                        filename: "\(name)@2x.\(OutputImageExtension.png.rawValue)"
-                    ),
-                    AssetImageDescription(
-                        idiom: "universal",
-                        scale: "3x",
-                        filename: "\(name)@3x.\(OutputImageExtension.png.rawValue)"
-                    )
-                ],
-                info: AssetInfo(
-                    version: 1,
-                    author: "ResgenSwift-Imagium"
-                )
-            )
+          "info" : {
+            "version" : 1,
+            "author" : "ResgenSwift-Imagium"
           }
         }
+        """
+    }
     
     // MARK: - Extension property
     

Sources/ResgenSwift/Images/Parser/ImageFileParser.swift

@@ -39,20 +39,10 @@ class ImageFileParser {
                 return Int(splittedLine[3])!
             }()
             
-            var imageExtensions: [ImageExtension] = []
-
-            splittedLine.forEach { stringExtension in
-                if let imageExtension = ImageExtension(rawValue: String(stringExtension)) {
-                    imageExtensions.append(imageExtension)
-                }
-            }
-
-            let image = ParsedImage(name: String(splittedLine[1]), tags: String(splittedLine[0]), width: width, height: height, imageExtensions: imageExtensions)
+            let image = ParsedImage(name: String(splittedLine[1]), tags: String(splittedLine[0]), width: width, height: height)
             imagesToGenerate.append(image)
         }
         
-        print(imagesToGenerate)
-
         return imagesToGenerate.filter {
             $0.tags.contains(platform.rawValue)
         }

Sources/ResgenSwift/Strings/Generator/StringsFileGenerator.swift

@@ -18,7 +18,6 @@ class StringsFileGenerator {
                                   tags: [String],
                                   outputPath: String,
                                   inputFilenameWithoutExt: String) {
-
         var stringsFilesContent = [String: String]()
         for lang in langs {
             stringsFilesContent[lang] = Self.generateStringsFileContent(lang: lang,
@@ -43,31 +42,6 @@ class StringsFileGenerator {
         }
     }
     
-    static func writeXcStringsFiles(sections: [Section],
-                                    langs: [String],
-                                    defaultLang: String,
-                                    tags: [String],
-                                    outputPath: String,
-                                    inputFilenameWithoutExt: String) {
-
-        let fileContent: String = Self.generateXcStringsFileContent(
-            langs: langs,
-            defaultLang: defaultLang,
-            tags: tags,
-            sections: sections
-        )
-
-        let stringsFilePath = "\(outputPath)/\(inputFilenameWithoutExt).xcstrings"
-        let stringsFilePathURL = URL(fileURLWithPath: stringsFilePath)
-        do {
-            try fileContent.write(to: stringsFilePathURL, atomically: false, encoding: .utf8)
-        } catch let error {
-            let error = StringiumError.writeFile(error.localizedDescription, stringsFilePath)
-            print(error.description)
-            Stringium.exit(withError: error)
-        }
-    }
-
     static func generateStringsFileContent(lang: String,
                                            defaultLang: String,
                                            tags inputTags: [String],
@@ -118,117 +92,6 @@ class StringsFileGenerator {
         return stringsFileContent
     }
     
-    // MARK: - XcStrings Generation
-
-    static func generateXcStringsFileContent(langs: [String],
-                                             defaultLang: String,
-                                             tags inputTags: [String],
-                                             sections: [Section]) -> String {
-        let rootObject = generateRootObject(langs: langs, defaultLang: defaultLang, tags: inputTags, sections: sections)
-        let file = generateXcStringsFileContentFromRootObject(rootObject: rootObject)
-
-        return file
-    }
-
-    static func generateXcStringsFileContentFromRootObject(rootObject: Root) -> String {
-        do {
-            let encoder = JSONEncoder()
-            encoder.outputFormatting = [.prettyPrinted]
-
-            let json = try encoder.encode(rootObject)
-
-            if let jsonString = String(data: json, encoding: .utf8) {
-                return jsonString
-            }
-
-        } catch {
-            debugPrint("Failed to encode: \(error)")
-        }
-
-        return ""
-    }
-
-    static func generateRootObject(langs: [String],
-                                   defaultLang: String,
-                                   tags inputTags: [String],
-                                   sections: [Section]) -> Root {
-
-        var xcStringDefinitionTab: [XCStringDefinition] = []
-
-        sections.forEach { section in
-            // Check that at least one string will be generated
-            guard section.hasOneOrMoreMatchingTags(tags: inputTags) else {
-                return // Go to next section
-            }
-
-            section.definitions.forEach { definition in
-                var skipDefinition = false
-                var isNoTranslation = false
-
-                var localizationTab: [XCStringLocalization] = []
-
-                if definition.hasOneOrMoreMatchingTags(inputTags: inputTags) == false {
-                    skipDefinition = true
-                }
-
-                if definition.tags.contains(Stringium.noTranslationTag) {
-                    isNoTranslation = true
-                }
-
-                if !skipDefinition {
-                    if isNoTranslation {
-                        // Search for langs in yaml
-                        for lang in langs {
-                            if let value = definition.translations[defaultLang], !value.isEmpty {
-                                let localization = XCStringLocalization(
-                                    lang: lang,
-                                    content: XCStringLocalizationLangContent(
-                                        stringUnit: DefaultStringUnit(state: "translated", value: value)
-                                    )
-                                )
-                                localizationTab.append(localization)
-                            }
-                        }
-                    } else {
-                        // Search for langs in twine
-                        for (lang, value) in definition.translations where !value.isEmpty {
-
-                            let localization = XCStringLocalization(
-                                lang: lang,
-                                content: XCStringLocalizationLangContent(
-                                    stringUnit: DefaultStringUnit(state: "translated", value: value)
-                                )
-                            )
-
-                            localizationTab.append(localization)
-                        }
-                    }
-
-                    let xcStringDefinition = XCStringDefinition(
-                        title: definition.name,
-                        content: XCStringDefinitionContent(
-                            comment: definition.comment,
-                            extractionState: "manual",
-                            localizations: XCStringLocalizationContainer(
-                                localizations: localizationTab
-                            )
-                        )
-                    )
-
-                    xcStringDefinitionTab.append(xcStringDefinition)
-                }
-            }
-        }
-
-        let xcStringContainer = XCStringDefinitionContainer(strings: xcStringDefinitionTab)
-        
-        return Root(
-            sourceLanguage: defaultLang,
-            strings: xcStringContainer,
-            version: "1.0"
-        )
-    }
-
     // MARK: - Extension file
     
     static func writeExtensionFiles(sections: [Section],

Sources/ResgenSwift/Strings/Model/Definition.swift

@@ -84,29 +84,22 @@ class Definition {
         return (inputParameters: inputParameters, translationArguments: translationArguments)
     }
     
-    private func getBaseProperty(lang: String, translation: String, isStatic: Bool, comment: String?) -> String {
+    private func getBaseProperty(lang: String, translation: String, isStatic: Bool) -> String {
         """
             /// Translation in \(lang) :
             /// \(translation)
-            ///
-            /// Comment :
-            /// \(comment?.isEmpty == false ? comment! : "No comment")
             \(isStatic ? "static ": "")var \(name): String {
-                NSLocalizedString("\(name)", tableName: kStringsFileName, bundle: Bundle.main, value: "\(translation)", comment: "\(comment ?? "")")
+                NSLocalizedString("\(name)", tableName: kStringsFileName, bundle: Bundle.main, value: "\(translation)", comment: "")
             }
         """
-
     }
     
-    private func getBaseMethod(lang: String, translation: String, isStatic: Bool, inputParameters: [String], translationArguments: [String], comment: String?) -> String {
-
+    private func getBaseMethod(lang: String, translation: String, isStatic: Bool, inputParameters: [String], translationArguments: [String]) -> String {
         """
             
+        
             /// Translation in \(lang) :
             /// \(translation)
-            ///
-            /// Comment :
-            /// \(comment?.isEmpty == false ? comment! : "No comment")
             \(isStatic ? "static ": "")func \(name)(\(inputParameters.joined(separator: ", "))) -> String {
                 String(format: \(isStatic ? "Self" : "self").\(name), \(translationArguments.joined(separator: ", ")))
             }
@@ -121,12 +114,7 @@ class Definition {
         }
 
         // Generate property
-        let property = getBaseProperty(
-            lang: lang,
-            translation: translation,
-            isStatic: false,
-            comment: self.comment
-        )
+        let property = getBaseProperty(lang: lang, translation: translation, isStatic: false)
         
         // Generate method
         var method = ""
@@ -135,8 +123,7 @@ class Definition {
                                    translation: translation,
                                    isStatic: false,
                                    inputParameters: parameters.inputParameters,
-                                   translationArguments: parameters.translationArguments,
-                                   comment: self.comment)
+                                   translationArguments: parameters.translationArguments)
         }
         
         return property + method
@@ -150,12 +137,7 @@ class Definition {
         }
         
         // Generate property
-        let property = getBaseProperty(
-            lang: lang,
-            translation: translation,
-            isStatic: true,
-            comment: self.comment
-        )
+        let property = getBaseProperty(lang: lang, translation: translation, isStatic: true)
         
         // Generate method
         var method = ""
@@ -164,8 +146,7 @@ class Definition {
                                    translation: translation,
                                    isStatic: true,
                                    inputParameters: parameters.inputParameters,
-                                   translationArguments: parameters.translationArguments,
-                                   comment: self.comment)
+                                   translationArguments: parameters.translationArguments)
         }
         
         return property + method
@@ -183,10 +164,6 @@ class Definition {
         return """
             /// Translation in \(lang) :
             /// \(translation)
-            ///
-            /// Comment :
-            /// \(comment?.isEmpty == false ? comment! : "No comment")
-
             var \(name): String {
                 "\(translation)"
             }
@@ -203,9 +180,6 @@ class Definition {
         return """
             /// Translation in \(lang) :
             /// \(translation)
-            ///
-            /// Comment :
-            /// \(comment?.isEmpty == false ? comment! : "No comment")
             static var \(name): String {
                 "\(translation)"
             }

Sources/ResgenSwift/Strings/Model/XcString.swift

@@ -1,109 +0,0 @@
-//
-//  XcString.swift
-//
-//
-//  Created by Quentin Bandera on 12/04/2024.
-//
-
-import SwiftUI
-
-struct DynamicKey: CodingKey {
-    var intValue: Int?
-    init?(intValue: Int) {
-        self.intValue = intValue
-        self.stringValue = "\(intValue)"
-    }
-
-    var stringValue: String
-    init?(stringValue: String) {
-        self.stringValue = stringValue
-    }
-}
-
-struct Root: Codable, Equatable {
-    let sourceLanguage: String
-    let strings: XCStringDefinitionContainer
-    let version: String
-}
-
-struct XCStringDefinitionContainer: Codable, Equatable {
-    let strings: [XCStringDefinition]
-
-    func encode(to encoder: Encoder) throws {
-        var container = encoder.container(keyedBy: DynamicKey.self)
-
-        for str in strings {
-            if let codingKey = DynamicKey(stringValue: str.title) {
-                try container.encode(str.content, forKey: codingKey)
-            }
-        }
-    }
-
-    static func == (lhs: XCStringDefinitionContainer, rhs: XCStringDefinitionContainer) -> Bool {
-        return lhs.strings.sorted(by: {
-            $0.title < $1.title
-        }) == rhs.strings.sorted(by: { $0.title < $1.title })
-    }
-}
-
-struct XCStringDefinition: Codable, Equatable {
-    let title: String // json key -> custom encoding methods
-    let content: XCStringDefinitionContent
-}
-
-struct XCStringDefinitionContent: Codable, Equatable {
-    let comment: String?
-    let extractionState: String
-    var localizations: XCStringLocalizationContainer
-
-    init(comment: String? = nil, extractionState: String, localizations: XCStringLocalizationContainer) {
-        self.comment = comment
-        self.extractionState = extractionState
-        self.localizations = localizations
-    }
-}
-
-struct XCStringLocalizationContainer: Codable, Equatable {
-    let localizations: [XCStringLocalization]
-
-    func encode(to encoder: Encoder) throws {
-        var container = encoder.container(keyedBy: DynamicKey.self)
-
-        for loca in localizations {
-            if let codingKey = DynamicKey(stringValue: loca.lang) {
-                try container.encode(loca.content, forKey: codingKey)
-            }
-        }
-    }
-
-    static func == (lhs: XCStringLocalizationContainer, rhs: XCStringLocalizationContainer) -> Bool {
-        return lhs.localizations.count == rhs.localizations.count && lhs.localizations.sorted(by: { $0.lang < $1.lang }) == rhs.localizations.sorted(by: { $0.lang < $1.lang })
-    }
-}
-
-struct XCStringLocalization: Codable, Equatable {
-    let lang: String // json key -> custom encoding method
-    let content: XCStringLocalizationLangContent
-}
-
-struct XCStringLocalizationLangContent: Codable, Equatable {
-    let stringUnit: DefaultStringUnit
-}
-
-//enum VarationOrStringUnit: Encodable {
-//    case variations([Varation])
-//    case stringUnit: (DefaultStringUnit)
-//
-//    func encode(to encoder: any Encoder) throws {
-//        if let varations {
-//
-//        } else if let  {
-//
-//        }
-//    }
-//}
-
-struct DefaultStringUnit: Codable, Equatable {
-    let state: String
-    let value: String
-}

Sources/ResgenSwift/Strings/Stringium/Stringium.swift

@@ -43,25 +43,12 @@ struct Stringium: ParsableCommand {
         let sections = TwineFileParser.parse(options.inputFile)
         
         // Generate strings files
-        print(options.xcStrings)
-        if !options.xcStrings {
-            print("[\(Self.toolName)] Will generate strings")
-
         StringsFileGenerator.writeStringsFiles(sections: sections,
                                                langs: options.langs,
                                                defaultLang: options.defaultLang,
                                                tags: options.tags,
                                                outputPath: options.stringsFileOutputPath,
                                                inputFilenameWithoutExt: options.inputFilenameWithoutExt)
-        } else {
-            print("[\(Self.toolName)] Will generate xcStrings")
-            StringsFileGenerator.writeXcStringsFiles(sections: sections,
-                                                     langs: options.langs,
-                                                     defaultLang: options.defaultLang,
-                                                     tags: options.tags,
-                                                     outputPath: options.stringsFileOutputPath,
-                                                     inputFilenameWithoutExt: options.inputFilenameWithoutExt)
-        }
         
         // Generate extension
         StringsFileGenerator.writeExtensionFiles(sections: sections,

Sources/ResgenSwift/Strings/Stringium/StringiumOptions.swift

@@ -12,7 +12,7 @@ struct StringiumOptions: ParsableArguments {
     @Flag(name: [.customShort("f"), .customShort("F")], help: "Should force generation")
     var forceGeneration = false
     
-    @Argument(help: "Input files where strings are defined.", transform: { $0.replaceTiltWithHomeDirectoryPath() })
+    @Argument(help: "Input files where strings ared defined.", transform: { $0.replaceTiltWithHomeDirectoryPath() })
     var inputFile: String
     
     @Option(name: .customLong("output-path"), help: "Path where to strings file.", transform: { $0.replaceTiltWithHomeDirectoryPath() })
@@ -33,9 +33,6 @@ struct StringiumOptions: ParsableArguments {
     @Option(help: "Tell if it will generate static properties or not")
     var staticMembers: Bool = false
     
-    @Option(help: "Tell if it will generate xcStrings file or not")
-    var xcStrings: Bool = false
-
     @Option(help: "Extension name. If not specified, it will generate an String extension.")
     var extensionName: String = Stringium.defaultExtensionName
     

Sources/ToolCore/StringExtensions.swift

@@ -89,19 +89,4 @@ public extension String {
     func uppercasedFirst() -> String {
         prefix(1).uppercased() + dropFirst()
     }
-
-    func replacingFirstOccurrence(of: String, with: String) -> Self {
-        if let range = self.range(of: of) {
-            let tmp = self.replacingOccurrences(
-                of: of,
-                with: with,
-                options: .literal,
-                range: range
-            )
-
-            return tmp
-        }
-
-        return self
-    }
 }

Tests/ResgenSwiftTests/Analytics/AnalyticsGeneratorTests.swift

@@ -51,7 +51,7 @@ final class AnalyticsGeneratorTests: XCTestCase {
         ]
         
         // When
-        AnalyticsGenerator.targets = [TrackerType.firebase]
+        AnalyticsGenerator.targets = [Analytics.TargetType.firebase]
         let extensionContent = AnalyticsGenerator.getExtensionContent(sections: [sectionOne, sectionTwo, sectionThree],
                                                                  tags: ["ios", "iosonly"],
                                                                  staticVar: false,
@@ -216,7 +216,7 @@ final class AnalyticsGeneratorTests: XCTestCase {
         ]
         
         // When
-        AnalyticsGenerator.targets = [TrackerType.matomo]
+        AnalyticsGenerator.targets = [Analytics.TargetType.matomo]
         let extensionContent = AnalyticsGenerator.getExtensionContent(sections: [sectionOne, sectionTwo, sectionThree],
                                                                  tags: ["ios", "iosonly"],
                                                                  staticVar: false,
@@ -409,7 +409,7 @@ final class AnalyticsGeneratorTests: XCTestCase {
         ]
         
         // When
-        AnalyticsGenerator.targets = [TrackerType.matomo, TrackerType.firebase]
+        AnalyticsGenerator.targets = [Analytics.TargetType.matomo, Analytics.TargetType.firebase]
         let extensionContent = AnalyticsGenerator.getExtensionContent(sections: [sectionOne, sectionTwo, sectionThree],
                                                                  tags: ["ios", "iosonly"],
                                                                  staticVar: false,

Tests/ResgenSwiftTests/Analytics/DiffString.swift

@@ -1,5 +1,5 @@
 //
-//  DiffString.swift
+//  File.swift
 //  
 //
 //  Created by Loris Perret on 06/12/2023.
@@ -7,6 +7,7 @@
 
 import Foundation
 
+
 /// Find first differing character between two strings
 ///
 /// :param: s1 First String

Tests/ResgenSwiftTests/Images/ImageFileParserTests.swift

@@ -17,8 +17,8 @@ class ImageFileParserTests: XCTestCase {
         #
         # SMAAS Support
         #
-        id image_one 25 ? png
-        di image_two ? 50 webp png
+        id image_one 25 ?
+        di image_two ? 50
         d image_three 25 ?
         d image_four 75 ?
         """
@@ -38,7 +38,6 @@ class ImageFileParserTests: XCTestCase {
         XCTAssertEqual(firstImage!.tags, "id")
         XCTAssertEqual(firstImage!.width, 25)
         XCTAssertEqual(firstImage!.height, -1)
-        XCTAssertEqual(firstImage!.imageExtensions, [.png])
         
         let secondImage = parsedImages.first {
             $0.name == "image_two"
@@ -47,6 +46,5 @@ class ImageFileParserTests: XCTestCase {
         XCTAssertEqual(secondImage!.tags, "di")
         XCTAssertEqual(secondImage!.width, -1)
         XCTAssertEqual(secondImage!.height, 50)        
-        XCTAssertEqual(firstImage!.imageExtensions, [.png])
     }
 }

Tests/ResgenSwiftTests/Images/ParsedImageTests.swift

@@ -127,77 +127,35 @@ final class ParsedImageTests: XCTestCase {
                                       height: 10)
         
         // When
-        let property = parsedImage.generateImageContent(isVector: false)
+        let property = parsedImage.contentJson
         
         // Expect
-        let expect = AssetContent(
-            images: [
-                AssetImageDescription(
-                    idiom: "universal",
-                    scale: "1x",
-                    filename: "\(parsedImage.name).\(OutputImageExtension.png.rawValue)"
-                ),
-                AssetImageDescription(
-                    idiom: "universal",
-                    scale: "2x",
-                    filename: "\(parsedImage.name)@2x.\(OutputImageExtension.png.rawValue)"
-                ),
-                AssetImageDescription(
-                    idiom: "universal",
-                    scale: "3x",
-                    filename: "\(parsedImage.name)@3x.\(OutputImageExtension.png.rawValue)"
-                )
+        let expect = """
+        {
+          "images" : [
+            {
+              "idiom" : "universal",
+              "scale" : "1x",
+              "filename" : "\(imageName).\(XcassetsGenerator.outputImageExtension)"
+            },
+            {
+              "idiom" : "universal",
+              "scale" : "2x",
+              "filename" : "\(imageName)@2x.\(XcassetsGenerator.outputImageExtension)"
+            },
+            {
+              "idiom" : "universal",
+              "scale" : "3x",
+              "filename" : "\(imageName)@3x.\(XcassetsGenerator.outputImageExtension)"
+            }
           ],
-            info: AssetInfo(
-                version: 1,
-                author: "ResgenSwift-Imagium"
-            )
-        )
-
-        XCTAssertEqual(property, expect)
-    }
-
-    func testAssetPng() {
-        // Given
-        let imageName = "the_name"
-        let parsedImage = ParsedImage(name: imageName,
-                                      tags: "id",
-                                      width: 10,
-                                      height: 10,
-                                      imageExtensions: [.png])
-
-        // When
-        let property = parsedImage.generateImageContent(isVector: false)
-
-        // Expect
-
-        let expect = AssetContent(
-            images: [
-                AssetImageDescription(
-                    idiom: "universal",
-                    scale: "1x",
-                    filename: "\(parsedImage.name).\(OutputImageExtension.png.rawValue)"
-                ),
-                AssetImageDescription(
-                    idiom: "universal",
-                    scale: "2x",
-                    filename: "\(parsedImage.name)@2x.\(OutputImageExtension.png.rawValue)"
-                ),
-                AssetImageDescription(
-                    idiom: "universal",
-                    scale: "3x",
-                    filename: "\(parsedImage.name)@3x.\(OutputImageExtension.png.rawValue)"
-                )
-            ],
-            info: AssetInfo(
-                version: 1,
-                author: "ResgenSwift-Imagium"
-            )
-        )
-
-        debugPrint(property)
-        debugPrint(expect)
-
-        XCTAssertEqual(property, expect)
+          "info" : {
+            "version" : 1,
+            "author" : "ResgenSwift-Imagium"
+          }
+        }
+        """
+        
+        XCTAssertEqual(property.adaptForXCTest(), expect.adaptForXCTest())
     }
 }

Tests/ResgenSwiftTests/Strings/DefinitionTests.swift

@@ -100,64 +100,6 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
         /// Translation in fr :
         /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// This is a comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "This is a comment")
-        }
-        """
-        
-        let expectEn = """
-        /// Translation in en :
-        /// This is the english translation
-        ///
-        /// Comment :
-        /// This is a comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "This is a comment")
-        }
-        """
-        
-        let expectEnUs = """
-        /// Translation in en-us :
-        /// This is the english us translation
-        ///
-        /// Comment :
-        /// This is a comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "This is a comment")
-        }
-        """
-        
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    func testGeneratedNSLocalizedStringPropertyWithEmptyComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.comment = ""
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getNSLocalizedStringProperty(forLang: "fr")
-        let propertyEn = definition.getNSLocalizedStringProperty(forLang: "en")
-        let propertyEnUs = definition.getNSLocalizedStringProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-        /// Translation in fr :
-        /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// No comment
         var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "")
         }
@@ -166,9 +108,6 @@ final class DefinitionTests: XCTestCase {
         let expectEn = """
         /// Translation in en :
         /// This is the english translation
-        ///
-        /// Comment :
-        /// No comment
         var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "")
         }
@@ -177,9 +116,6 @@ final class DefinitionTests: XCTestCase {
         let expectEnUs = """
         /// Translation in en-us :
         /// This is the english us translation
-        ///
-        /// Comment :
-        /// No comment
         var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "")
         }
@@ -190,62 +126,6 @@ final class DefinitionTests: XCTestCase {
         XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
     }
     
-    func testGeneratedNSLocalizedStringPropertyWithNoComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getNSLocalizedStringProperty(forLang: "fr")
-        let propertyEn = definition.getNSLocalizedStringProperty(forLang: "en")
-        let propertyEnUs = definition.getNSLocalizedStringProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-        /// Translation in fr :
-        /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// No comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "")
-        }
-        """
-
-        let expectEn = """
-        /// Translation in en :
-        /// This is the english translation
-        ///
-        /// Comment :
-        /// No comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "")
-        }
-        """
-
-        let expectEnUs = """
-        /// Translation in en-us :
-        /// This is the english us translation
-        ///
-        /// Comment :
-        /// No comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "")
-        }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    // MARK: - getNSLocalizedStringStaticProperty
-
     func testGeneratedNSLocalizedStringStaticProperty() {
         // Given
         let definition = Definition(name: "definition_name")
@@ -266,64 +146,6 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
         /// Translation in fr :
         /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// This is a comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "This is a comment")
-        }
-        """
-        
-        let expectEn = """
-        /// Translation in en :
-        /// This is the english translation
-        ///
-        /// Comment :
-        /// This is a comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "This is a comment")
-        }
-        """
-        
-        let expectEnUs = """
-        /// Translation in en-us :
-        /// This is the english us translation
-        ///
-        /// Comment :
-        /// This is a comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "This is a comment")
-        }
-        """
-        
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    func testGeneratedNSLocalizedStringStaticPropertyWithEmptyComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.comment = ""
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getNSLocalizedStringStaticProperty(forLang: "fr")
-        let propertyEn = definition.getNSLocalizedStringStaticProperty(forLang: "en")
-        let propertyEnUs = definition.getNSLocalizedStringStaticProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-        /// Translation in fr :
-        /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// No comment
         static var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "")
         }
@@ -332,9 +154,6 @@ final class DefinitionTests: XCTestCase {
         let expectEn = """
         /// Translation in en :
         /// This is the english translation
-        ///
-        /// Comment :
-        /// No comment
         static var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "")
         }
@@ -343,63 +162,6 @@ final class DefinitionTests: XCTestCase {
         let expectEnUs = """
         /// Translation in en-us :
         /// This is the english us translation
-        ///
-        /// Comment :
-        /// No comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "")
-        }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    func testGeneratedNSLocalizedStringStaticPropertyWithNoComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getNSLocalizedStringStaticProperty(forLang: "fr")
-        let propertyEn = definition.getNSLocalizedStringStaticProperty(forLang: "en")
-        let propertyEnUs = definition.getNSLocalizedStringStaticProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-        /// Translation in fr :
-        /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// No comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "")
-        }
-        """
-
-        let expectEn = """
-        /// Translation in en :
-        /// This is the english translation
-        ///
-        /// Comment :
-        /// No comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "")
-        }
-        """
-
-        let expectEnUs = """
-        /// Translation in en-us :
-        /// This is the english us translation
-        ///
-        /// Comment :
-        /// No comment
         static var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "")
         }
@@ -426,18 +188,12 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
         /// Translation in fr :
         /// Welcome "%@" !
-        ///
-        /// Comment :
-        /// This is a comment
         var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Welcome \"%@\" !", comment: "This is a comment")
+            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Welcome \"%@\" !", comment: "")
         }
         
         /// Translation in fr :
         /// Welcome "%@" !
-        ///
-        /// Comment :
-        /// This is a comment
         func definition_name(arg0: String) -> String {
             String(format: self.definition_name, arg0)
         }
@@ -462,18 +218,12 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
         /// Translation in fr :
         /// Welcome "%@" ! Your age is %d :) Your weight is %f ;-)
-        ///
-        /// Comment :
-        /// This is a comment
         var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Welcome \"%@\" ! Your age is %d :) Your weight is %f ;-)", comment: "This is a comment")
+            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Welcome \"%@\" ! Your age is %d :) Your weight is %f ;-)", comment: "")
         }
         
         /// Translation in fr :
         /// Welcome "%@" ! Your age is %d :) Your weight is %f ;-)
-        ///
-        /// Comment :
-        /// This is a comment
         func definition_name(arg0: String, arg1: Int, arg2: Double) -> String {
             String(format: self.definition_name, arg0, arg1, arg2)
         }
@@ -499,18 +249,12 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
         /// Translation in fr :
         /// Vous %%: %1$@ %2$@ Age: %3$d
-        ///
-        /// Comment :
-        /// This is a comment
         var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Vous %%: %1$@ %2$@ Age: %3$d", comment: "This is a comment")
+            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Vous %%: %1$@ %2$@ Age: %3$d", comment: "")
         }
         
         /// Translation in fr :
         /// Vous %%: %1$@ %2$@ Age: %3$d
-        ///
-        /// Comment :
-        /// This is a comment
         func definition_name(arg0: String, arg1: String, arg2: Int) -> String {
             String(format: self.definition_name, arg0, arg1, arg2)
         }
@@ -519,18 +263,12 @@ final class DefinitionTests: XCTestCase {
         let expectEn = """
         /// Translation in en :
         /// You %%: %2$@ %1$@ Age: %3$d
-        ///
-        /// Comment :
-        /// This is a comment
         var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "You %%: %2$@ %1$@ Age: %3$d", comment: "This is a comment")
+            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "You %%: %2$@ %1$@ Age: %3$d", comment: "")
         }
         
         /// Translation in en :
         /// You %%: %2$@ %1$@ Age: %3$d
-        ///
-        /// Comment :
-        /// This is a comment
         func definition_name(arg0: String, arg1: String, arg2: Int) -> String {
             String(format: self.definition_name, arg0, arg1, arg2)
         }
@@ -562,9 +300,6 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
             /// Translation in fr :
             /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// This is a comment
             var definition_name: String {
                 "C'est la traduction francaise"
             }
@@ -573,9 +308,6 @@ final class DefinitionTests: XCTestCase {
         let expectEn = """
             /// Translation in en :
             /// This is the english translation
-            ///
-            /// Comment :
-            /// This is a comment
             var definition_name: String {
                 "This is the english translation"
             }
@@ -584,9 +316,6 @@ final class DefinitionTests: XCTestCase {
         let expectEnUs = """
             /// Translation in en-us :
             /// This is the english us translation
-            ///
-            /// Comment :
-            /// This is a comment
             var definition_name: String {
                 "This is the english us translation"
             }
@@ -597,117 +326,6 @@ final class DefinitionTests: XCTestCase {
         XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
     }
     
-    func testGeneratedRawPropertyWithEmptyComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.comment = ""
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getProperty(forLang: "fr")
-        let propertyEn = definition.getProperty(forLang: "en")
-        let propertyEnUs = definition.getProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-            /// Translation in fr :
-            /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "C'est la traduction francaise"
-            }
-        """
-
-        let expectEn = """
-            /// Translation in en :
-            /// This is the english translation
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "This is the english translation"
-            }
-        """
-
-        let expectEnUs = """
-            /// Translation in en-us :
-            /// This is the english us translation
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "This is the english us translation"
-            }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    func testGeneratedRawPropertyWithNoComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getProperty(forLang: "fr")
-        let propertyEn = definition.getProperty(forLang: "en")
-        let propertyEnUs = definition.getProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-            /// Translation in fr :
-            /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "C'est la traduction francaise"
-            }
-        """
-
-        let expectEn = """
-            /// Translation in en :
-            /// This is the english translation
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "This is the english translation"
-            }
-        """
-
-        let expectEnUs = """
-            /// Translation in en-us :
-            /// This is the english us translation
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "This is the english us translation"
-            }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    // MARK: - Raw static properties
-
     func testGeneratedRawStaticProperty() {
         // Given
         let definition = Definition(name: "definition_name")
@@ -728,9 +346,6 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
             /// Translation in fr :
             /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// This is a comment
             static var definition_name: String {
                 "C'est la traduction francaise"
             }
@@ -739,9 +354,6 @@ final class DefinitionTests: XCTestCase {
         let expectEn = """
             /// Translation in en :
             /// This is the english translation
-            ///
-            /// Comment :
-            /// This is a comment
                         static var definition_name: String {
                 "This is the english translation"
             }
@@ -750,118 +362,6 @@ final class DefinitionTests: XCTestCase {
         let expectEnUs = """
             /// Translation in en-us :
             /// This is the english us translation
-            ///
-            /// Comment :
-            /// This is a comment
-            static var definition_name: String {
-                "This is the english us translation"
-            }
-        """
-        
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    func testGeneratedRawStaticPropertyWithEmptyComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.comment = ""
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getStaticProperty(forLang: "fr")
-        let propertyEn = definition.getStaticProperty(forLang: "en")
-        let propertyEnUs = definition.getStaticProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-            /// Translation in fr :
-            /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "C'est la traduction francaise"
-            }
-        """
-
-        let expectEn = """
-            /// Translation in en :
-            /// This is the english translation
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "This is the english translation"
-            }
-        """
-
-        let expectEnUs = """
-            /// Translation in en-us :
-            /// This is the english us translation
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "This is the english us translation"
-            }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    func testGeneratedRawStaticPropertyWithNoComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getStaticProperty(forLang: "fr")
-        let propertyEn = definition.getStaticProperty(forLang: "en")
-        let propertyEnUs = definition.getStaticProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-            /// Translation in fr :
-            /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "C'est la traduction francaise"
-            }
-        """
-
-        let expectEn = """
-            /// Translation in en :
-            /// This is the english translation
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "This is the english translation"
-            }
-        """
-
-        let expectEnUs = """
-            /// Translation in en-us :
-            /// This is the english us translation
-            ///
-            /// Comment :
-            /// No comment
             static var definition_name: String {
                 "This is the english us translation"
             }