Prise en compte des premiers retorus

Package.resolved

@@ -14,8 +14,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/krzyzanowskim/CryptoSwift.git",
       "state" : {
-        "revision" : "c9c3df6ab812de32bae61fc0cd1bf6d45170ebf0",
+        "revision" : "db51c407d3be4a051484a141bf0bff36c43d3b1e",
-        "version" : "1.8.2"
+        "version" : "1.8.0"
       }
     },
     {

Sources/ResgenSwift/Generate/GenerateError.swift

@@ -9,7 +9,7 @@ import Foundation
 
 enum GenerateError: Error {
     case fileNotExists(String)
-    case invalidConfigurationFile(String, String)
+    case invalidConfigurationFile(String)
     case commandError([String], String)
     case writeFile(String, String)
     
@@ -18,8 +18,8 @@ enum GenerateError: Error {
         case .fileNotExists(let filename):
             return "error: [\(Generate.toolName)] File \(filename) does not exists"
     
-        case .invalidConfigurationFile(let filename, let underneathErrorDescription):
+        case .invalidConfigurationFile(let filename):
-            return "error: [\(Generate.toolName)] File \(filename) is not a valid configuration file. Underneath error: \(underneathErrorDescription)"
+            return "error: [\(Generate.toolName)] File \(filename) is not a valid configuration file"
             
         case .commandError(let command, let terminationStatus):
             let readableCommand = command

Sources/ResgenSwift/Generate/Model/ConfigurationFile.swift

@@ -269,22 +269,14 @@ struct StringsConfiguration: Codable, CustomDebugStringConvertible {
     let extensionName: String?
     let extensionSuffix: String?
     private let staticMembers: Bool?
-    private let xcStrings: Bool?
+    
-
     var staticMembersOptions: Bool {
         if let staticMembers = staticMembers {
             return staticMembers
         }
         return false
     }
-
+    
-    var xcStringsOptions: Bool {
-        if let xcStrings = xcStrings {
-            return xcStrings
-        }
-        return false
-    }
-
     internal init(inputFile: String,
                   outputPath: String,
                   langs: String,
@@ -292,8 +284,7 @@ struct StringsConfiguration: Codable, CustomDebugStringConvertible {
                   extensionOutputPath: String,
                   extensionName: String?,
                   extensionSuffix: String?,
-                  staticMembers: Bool?,
+                  staticMembers: Bool?) {
-                  xcStrings: Bool?) {
         self.inputFile = inputFile
         self.outputPath = outputPath
         self.langs = langs
@@ -302,7 +293,6 @@ struct StringsConfiguration: Codable, CustomDebugStringConvertible {
         self.extensionName = extensionName
         self.extensionSuffix = extensionSuffix
         self.staticMembers = staticMembers
-        self.xcStrings = xcStrings
     }
     
     var debugDescription: String {

Sources/ResgenSwift/Generate/Parser/ConfigurationFileParser.swift

@@ -16,15 +16,12 @@ class ConfigurationFileParser {
             Generate.exit(withError: error)
         }
         
-        do {
+        guard let configuration = try? YAMLDecoder().decode(ConfigurationFile.self, from: data) else {
-            return try YAMLDecoder().decode(ConfigurationFile.self, from: data)
+            let error = GenerateError.invalidConfigurationFile(configurationFile)
-        } catch {
-            let error = GenerateError.invalidConfigurationFile(
-                configurationFile,
-                error.localizedDescription.description
-            )
             print(error.description)
             Generate.exit(withError: error)
         }
+        
+        return configuration
     }
 }

Sources/ResgenSwift/Generate/Runnable/StringsConfiguration+Runnable.swift

@@ -14,7 +14,7 @@ extension StringsConfiguration: Runnable {
         if force {
             args += ["-f"]
         }
-
+        
         args += [
             inputFile.prependIfRelativePath(projectDirectory),
             "--output-path",
@@ -26,9 +26,7 @@ extension StringsConfiguration: Runnable {
             "--extension-output-path",
             extensionOutputPath.prependIfRelativePath(projectDirectory),
             "--static-members",
-            "\(staticMembersOptions)",
+            "\(staticMembersOptions)"
-            "--xc-strings",
-            "\(xcStringsOptions)"
         ]
         
         if let extensionName = extensionName {

Sources/ResgenSwift/Strings/Generator/StringsFileGenerator.swift

@@ -1,6 +1,6 @@
 //
 //  StringsFileGenerator.swift
-//
+//  
 //
 //  Created by Thibaut Schmitt on 04/01/2022.
 //
@@ -9,16 +9,15 @@ import Foundation
 import ToolCore
 
 class StringsFileGenerator {
-
+    
     // MARK: - Strings Files
-
+    
     static func writeStringsFiles(sections: [Section],
                                   langs: [String],
                                   defaultLang: String,
                                   tags: [String],
                                   outputPath: String,
                                   inputFilenameWithoutExt: String) {
-
         var stringsFilesContent = [String: String]()
         for lang in langs {
             stringsFilesContent[lang] = Self.generateStringsFileContent(lang: lang,
@@ -26,11 +25,11 @@ class StringsFileGenerator {
                                                                         tags: tags,
                                                                         sections: sections)
         }
-
+        
         // Write strings file content
         langs.forEach { lang in
             guard let fileContent = stringsFilesContent[lang] else { return }
-
+            
             let stringsFilePath = "\(outputPath)/\(lang).lproj/\(inputFilenameWithoutExt).strings"
             let stringsFilePathURL = URL(fileURLWithPath: stringsFilePath)
             do {
@@ -42,32 +41,7 @@ class StringsFileGenerator {
             }
         }
     }
-
+    
-    static func writeXcStringsFiles(sections: [Section],
-                                    langs: [String],
-                                    defaultLang: String,
-                                    tags: [String],
-                                    outputPath: String,
-                                    inputFilenameWithoutExt: String) {
-
-        let fileContent: String = Self.generateXcStringsFileContent(
-            langs: langs,
-            defaultLang: defaultLang,
-            tags: tags,
-            sections: sections
-        )
-
-        let stringsFilePath = "\(outputPath)/\(inputFilenameWithoutExt).xcstrings"
-        let stringsFilePathURL = URL(fileURLWithPath: stringsFilePath)
-        do {
-            try fileContent.write(to: stringsFilePathURL, atomically: false, encoding: .utf8)
-        } catch let error {
-            let error = StringiumError.writeFile(error.localizedDescription, stringsFilePath)
-            print(error.description)
-            Stringium.exit(withError: error)
-        }
-    }
-
     static func generateStringsFileContent(lang: String,
                                            defaultLang: String,
                                            tags inputTags: [String],
@@ -79,13 +53,13 @@ class StringsFileGenerator {
          * Language: \(lang)
          */\n
         """
-
+        
         sections.forEach { section in
             // Check that at least one string will be generated
             guard section.hasOneOrMoreMatchingTags(tags: inputTags) else {
                 return // Go to next section
             }
-
+            
             stringsFileContent += "\n/********** \(section.name) **********/\n\n"
             section.definitions.forEach { definition in
                 var skipDefinition = false // Set to true if not matching tag
@@ -95,16 +69,16 @@ class StringsFileGenerator {
                         skipDefinition = true
                         return nil
                     }
-
+                    
                     // If tags contains `noTranslationTag` => get default lang
                     if definition.tags.contains(Stringium.noTranslationTag) {
                         return definition.translations[defaultLang]
                     }
-
+                    
                     // Else: get specific lang
                     return definition.translations[lang]
                 }()
-
+                
                 if let translation = translationOpt {
                     stringsFileContent += "\"\(definition.name)\" = \"\(translation)\";\n\n"
                 } else if skipDefinition == false {
@@ -114,123 +88,12 @@ class StringsFileGenerator {
                 }
             }
         }
-
+        
         return stringsFileContent
     }
-
+    
-    // MARK: - XcStrings Generation
-
-    static func generateXcStringsFileContent(langs: [String],
-                                             defaultLang: String,
-                                             tags inputTags: [String],
-                                             sections: [Section]) -> String {
-        let rootObject = generateRootObject(langs: langs, defaultLang: defaultLang, tags: inputTags, sections: sections)
-        let file = generateXcStringsFileContentFromRootObject(rootObject: rootObject)
-
-        return file
-    }
-
-    static func generateXcStringsFileContentFromRootObject(rootObject: Root) -> String {
-        do {
-            let encoder = JSONEncoder()
-            encoder.outputFormatting = [.prettyPrinted]
-
-            let json = try encoder.encode(rootObject)
-
-            if let jsonString = String(data: json, encoding: .utf8) {
-                return jsonString
-            }
-
-        } catch {
-            debugPrint("Failed to encode: \(error)")
-        }
-
-        return ""
-    }
-
-    static func generateRootObject(langs: [String],
-                                   defaultLang: String,
-                                   tags inputTags: [String],
-                                   sections: [Section]) -> Root {
-
-        var xcStringDefinitionTab: [XCStringDefinition] = []
-
-        sections.forEach { section in
-            // Check that at least one string will be generated
-            guard section.hasOneOrMoreMatchingTags(tags: inputTags) else {
-                return // Go to next section
-            }
-
-            section.definitions.forEach { definition in
-                var skipDefinition = false
-                var isNoTranslation = false
-
-                var localizationTab: [XCStringLocalization] = []
-
-                if definition.hasOneOrMoreMatchingTags(inputTags: inputTags) == false {
-                    skipDefinition = true
-                }
-
-                if definition.tags.contains(Stringium.noTranslationTag) {
-                    isNoTranslation = true
-                }
-
-                if !skipDefinition {
-                    if isNoTranslation {
-                        // Search for langs in yaml
-                        for lang in langs {
-                            if let value = definition.translations[defaultLang], !value.isEmpty {
-                                let localization = XCStringLocalization(
-                                    lang: lang,
-                                    content: XCStringLocalizationLangContent(
-                                        stringUnit: DefaultStringUnit(state: "translated", value: value)
-                                    )
-                                )
-                                localizationTab.append(localization)
-                            }
-                        }
-                    } else {
-                        // Search for langs in twine
-                        for (lang, value) in definition.translations where !value.isEmpty {
-
-                            let localization = XCStringLocalization(
-                                lang: lang,
-                                content: XCStringLocalizationLangContent(
-                                    stringUnit: DefaultStringUnit(state: "translated", value: value)
-                                )
-                            )
-
-                            localizationTab.append(localization)
-                        }
-                    }
-
-                    let xcStringDefinition = XCStringDefinition(
-                        title: definition.name,
-                        content: XCStringDefinitionContent(
-                            comment: definition.comment,
-                            extractionState: "manual",
-                            localizations: XCStringLocalizationContainer(
-                                localizations: localizationTab
-                            )
-                        )
-                    )
-
-                    xcStringDefinitionTab.append(xcStringDefinition)
-                }
-            }
-        }
-
-        let xcStringContainer = XCStringDefinitionContainer(strings: xcStringDefinitionTab)
-        
-        return Root(
-            sourceLanguage: defaultLang,
-            strings: xcStringContainer,
-            version: "1.0"
-        )
-    }
-
     // MARK: - Extension file
-
+    
     static func writeExtensionFiles(sections: [Section],
                                     defaultLang lang: String,
                                     tags: [String],
@@ -247,7 +110,7 @@ class StringsFileGenerator {
                                                             inputFilename: inputFilename,
                                                             extensionName: extensionName,
                                                             extensionSuffix: extensionSuffix)
-
+        
         // Write content
         let extensionFilePathURL = URL(fileURLWithPath: extensionFilePath)
         do {
@@ -258,9 +121,9 @@ class StringsFileGenerator {
             Stringium.exit(withError: error)
         }
     }
-
+    
     // MARK: - Extension content
-
+    
     static func getExtensionContent(sections: [Section],
                                     defaultLang lang: String,
                                     tags: [String],
@@ -276,31 +139,31 @@ class StringsFileGenerator {
         ]
             .joined(separator: "\n")
     }
-
+    
     // MARK: - Extension part
-
+    
     private static func getHeader(stringsFilename: String, extensionClassname: String) -> String {
         """
         // Generated by ResgenSwift.Strings.\(Stringium.toolName) \(ResgenSwiftVersion)
-
+        
         import UIKit
-
+        
         fileprivate let kStringsFileName = "\(stringsFilename)"
-
+        
         extension \(extensionClassname) {
         """
     }
-
+    
     private static func getEnumKey(sections: [Section], tags: [String], extensionClassname: String, extensionSuffix: String) -> String {
         var enumDefinition = "\n    enum Key\(extensionSuffix.uppercasedFirst()): String {\n"
-
+        
         // Enum
         sections.forEach { section in
             // Check that at least one string will be generated
             guard section.hasOneOrMoreMatchingTags(tags: tags) else {
                 return // Go to next section
             }
-
+            
             section.definitions.forEach { definition in
                 guard definition.hasOneOrMoreMatchingTags(inputTags: tags) == true else {
                     return // Go to next definition
@@ -309,7 +172,7 @@ class StringsFileGenerator {
                 enumDefinition += "        case \(definition.name) = \"\(definition.name)\"\n"
             }
         }
-
+        
         // KeyPath accessors
         enumDefinition += "\n"
         enumDefinition += "        var keyPath: KeyPath<\(extensionClassname), String> {\n"
@@ -319,7 +182,7 @@ class StringsFileGenerator {
             guard section.hasOneOrMoreMatchingTags(tags: tags) else {
                 return // Go to next section
             }
-
+            
             section.definitions.forEach { definition in
                 guard definition.hasOneOrMoreMatchingTags(inputTags: tags) == true else {
                     return // Go to next definition
@@ -331,23 +194,23 @@ class StringsFileGenerator {
         enumDefinition += "            }\n" // Switch
         enumDefinition += "        }\n" // var keyPath
         enumDefinition += "    }" // Enum
-
+        
         return enumDefinition
     }
-
+    
     private static func getProperties(sections: [Section], defaultLang lang: String, tags: [String], staticVar: Bool) -> String {
         sections.compactMap { section in
             // Check that at least one string will be generated
             guard section.hasOneOrMoreMatchingTags(tags: tags) else {
                 return nil // Go to next section
             }
-
+            
             var res = "\n    // MARK: - \(section.name)\n"
             res += section.definitions.compactMap { definition in
                 guard definition.hasOneOrMoreMatchingTags(inputTags: tags) == true else {
                     return nil // Go to next definition
                 }
-
+                
                 if staticVar {
                     return "\n\(definition.getNSLocalizedStringStaticProperty(forLang: lang))"
                 }
@@ -358,11 +221,11 @@ class StringsFileGenerator {
         }
         .joined(separator: "\n")
     }
-
+    
     private static func getFooter() -> String {
         """
         }
-
+        
         """
     }
 }

Sources/ResgenSwift/Strings/Model/Definition.swift

@@ -84,29 +84,22 @@ class Definition {
         return (inputParameters: inputParameters, translationArguments: translationArguments)
     }
     
-    private func getBaseProperty(lang: String, translation: String, isStatic: Bool, comment: String?) -> String {
+    private func getBaseProperty(lang: String, translation: String, isStatic: Bool) -> String {
         """
             /// Translation in \(lang) :
             /// \(translation)
-            ///
-            /// Comment :
-            /// \(comment?.isEmpty == false ? comment! : "No comment")
             \(isStatic ? "static ": "")var \(name): String {
-                NSLocalizedString("\(name)", tableName: kStringsFileName, bundle: Bundle.main, value: "\(translation)", comment: "\(comment ?? "")")
+                NSLocalizedString("\(name)", tableName: kStringsFileName, bundle: Bundle.main, value: "\(translation)", comment: "")
             }
         """
-
     }
     
-    private func getBaseMethod(lang: String, translation: String, isStatic: Bool, inputParameters: [String], translationArguments: [String], comment: String?) -> String {
+    private func getBaseMethod(lang: String, translation: String, isStatic: Bool, inputParameters: [String], translationArguments: [String]) -> String {
-
         """
-
+            
+        
             /// Translation in \(lang) :
             /// \(translation)
-            ///
-            /// Comment :
-            /// \(comment?.isEmpty == false ? comment! : "No comment")
             \(isStatic ? "static ": "")func \(name)(\(inputParameters.joined(separator: ", "))) -> String {
                 String(format: \(isStatic ? "Self" : "self").\(name), \(translationArguments.joined(separator: ", ")))
             }
@@ -121,13 +114,8 @@ class Definition {
         }
 
         // Generate property
-        let property = getBaseProperty(
+        let property = getBaseProperty(lang: lang, translation: translation, isStatic: false)
-            lang: lang,
+        
-            translation: translation,
-            isStatic: false,
-            comment: self.comment
-        )
-
         // Generate method
         var method = ""
         if let parameters = self.getStringParameters(input: translation) {
@@ -135,8 +123,7 @@ class Definition {
                                    translation: translation,
                                    isStatic: false,
                                    inputParameters: parameters.inputParameters,
-                                   translationArguments: parameters.translationArguments,
+                                   translationArguments: parameters.translationArguments)
-                                   comment: self.comment)
         }
         
         return property + method
@@ -150,12 +137,7 @@ class Definition {
         }
         
         // Generate property
-        let property = getBaseProperty(
+        let property = getBaseProperty(lang: lang, translation: translation, isStatic: true)
-            lang: lang,
-            translation: translation,
-            isStatic: true,
-            comment: self.comment
-        )
         
         // Generate method
         var method = ""
@@ -164,8 +146,7 @@ class Definition {
                                    translation: translation,
                                    isStatic: true,
                                    inputParameters: parameters.inputParameters,
-                                   translationArguments: parameters.translationArguments,
+                                   translationArguments: parameters.translationArguments)
-                                   comment: self.comment)
         }
         
         return property + method
@@ -179,14 +160,10 @@ class Definition {
             print(error.description)
             Stringium.exit(withError: error)
         }
-
+        
         return """
             /// Translation in \(lang) :
             /// \(translation)
-            ///
-            /// Comment :
-            /// \(comment?.isEmpty == false ? comment! : "No comment")
-
             var \(name): String {
                 "\(translation)"
             }
@@ -203,9 +180,6 @@ class Definition {
         return """
             /// Translation in \(lang) :
             /// \(translation)
-            ///
-            /// Comment :
-            /// \(comment?.isEmpty == false ? comment! : "No comment")
             static var \(name): String {
                 "\(translation)"
             }

Sources/ResgenSwift/Strings/Model/XcString.swift

@@ -1,109 +0,0 @@
-//
-//  XcString.swift
-//
-//
-//  Created by Quentin Bandera on 12/04/2024.
-//
-
-import SwiftUI
-
-struct DynamicKey: CodingKey {
-    var intValue: Int?
-    init?(intValue: Int) {
-        self.intValue = intValue
-        self.stringValue = "\(intValue)"
-    }
-
-    var stringValue: String
-    init?(stringValue: String) {
-        self.stringValue = stringValue
-    }
-}
-
-struct Root: Codable, Equatable {
-    let sourceLanguage: String
-    let strings: XCStringDefinitionContainer
-    let version: String
-}
-
-struct XCStringDefinitionContainer: Codable, Equatable {
-    let strings: [XCStringDefinition]
-
-    func encode(to encoder: Encoder) throws {
-        var container = encoder.container(keyedBy: DynamicKey.self)
-
-        for str in strings {
-            if let codingKey = DynamicKey(stringValue: str.title) {
-                try container.encode(str.content, forKey: codingKey)
-            }
-        }
-    }
-
-    static func == (lhs: XCStringDefinitionContainer, rhs: XCStringDefinitionContainer) -> Bool {
-        return lhs.strings.sorted(by: {
-            $0.title < $1.title
-        }) == rhs.strings.sorted(by: { $0.title < $1.title })
-    }
-}
-
-struct XCStringDefinition: Codable, Equatable {
-    let title: String // json key -> custom encoding methods
-    let content: XCStringDefinitionContent
-}
-
-struct XCStringDefinitionContent: Codable, Equatable {
-    let comment: String?
-    let extractionState: String
-    var localizations: XCStringLocalizationContainer
-
-    init(comment: String? = nil, extractionState: String, localizations: XCStringLocalizationContainer) {
-        self.comment = comment
-        self.extractionState = extractionState
-        self.localizations = localizations
-    }
-}
-
-struct XCStringLocalizationContainer: Codable, Equatable {
-    let localizations: [XCStringLocalization]
-
-    func encode(to encoder: Encoder) throws {
-        var container = encoder.container(keyedBy: DynamicKey.self)
-
-        for loca in localizations {
-            if let codingKey = DynamicKey(stringValue: loca.lang) {
-                try container.encode(loca.content, forKey: codingKey)
-            }
-        }
-    }
-
-    static func == (lhs: XCStringLocalizationContainer, rhs: XCStringLocalizationContainer) -> Bool {
-        return lhs.localizations.count == rhs.localizations.count && lhs.localizations.sorted(by: { $0.lang < $1.lang }) == rhs.localizations.sorted(by: { $0.lang < $1.lang })
-    }
-}
-
-struct XCStringLocalization: Codable, Equatable {
-    let lang: String // json key -> custom encoding method
-    let content: XCStringLocalizationLangContent
-}
-
-struct XCStringLocalizationLangContent: Codable, Equatable {
-    let stringUnit: DefaultStringUnit
-}
-
-//enum VarationOrStringUnit: Encodable {
-//    case variations([Varation])
-//    case stringUnit: (DefaultStringUnit)
-//
-//    func encode(to encoder: any Encoder) throws {
-//        if let varations {
-//
-//        } else if let  {
-//
-//        }
-//    }
-//}
-
-struct DefaultStringUnit: Codable, Equatable {
-    let state: String
-    let value: String
-}

Sources/ResgenSwift/Strings/Stringium/Stringium.swift

@@ -43,26 +43,13 @@ struct Stringium: ParsableCommand {
         let sections = TwineFileParser.parse(options.inputFile)
         
         // Generate strings files
-        print(options.xcStrings)
+        StringsFileGenerator.writeStringsFiles(sections: sections,
-        if !options.xcStrings {
+                                               langs: options.langs,
-            print("[\(Self.toolName)] Will generate strings")
+                                               defaultLang: options.defaultLang,
-
+                                               tags: options.tags,
-            StringsFileGenerator.writeStringsFiles(sections: sections,
+                                               outputPath: options.stringsFileOutputPath,
-                                                   langs: options.langs,
+                                               inputFilenameWithoutExt: options.inputFilenameWithoutExt)
-                                                   defaultLang: options.defaultLang,
+        
-                                                   tags: options.tags,
-                                                   outputPath: options.stringsFileOutputPath,
-                                                   inputFilenameWithoutExt: options.inputFilenameWithoutExt)
-        } else {
-            print("[\(Self.toolName)] Will generate xcStrings")
-            StringsFileGenerator.writeXcStringsFiles(sections: sections,
-                                                     langs: options.langs,
-                                                     defaultLang: options.defaultLang,
-                                                     tags: options.tags,
-                                                     outputPath: options.stringsFileOutputPath,
-                                                     inputFilenameWithoutExt: options.inputFilenameWithoutExt)
-        }
-
         // Generate extension
         StringsFileGenerator.writeExtensionFiles(sections: sections,
                                                  defaultLang: options.defaultLang,
@@ -72,7 +59,7 @@ struct Stringium: ParsableCommand {
                                                  extensionName: options.extensionName,
                                                  extensionFilePath: options.extensionFilePath,
                                                  extensionSuffix: options.extensionSuffix)
-
+        
         print("[\(Self.toolName)] Strings generated")
     }
     

Sources/ResgenSwift/Strings/Stringium/StringiumOptions.swift

@@ -11,8 +11,8 @@ import ArgumentParser
 struct StringiumOptions: ParsableArguments {
     @Flag(name: [.customShort("f"), .customShort("F")], help: "Should force generation")
     var forceGeneration = false
-
+    
-    @Argument(help: "Input files where strings are defined.", transform: { $0.replaceTiltWithHomeDirectoryPath() })
+    @Argument(help: "Input files where strings ared defined.", transform: { $0.replaceTiltWithHomeDirectoryPath() })
     var inputFile: String
     
     @Option(name: .customLong("output-path"), help: "Path where to strings file.", transform: { $0.replaceTiltWithHomeDirectoryPath() })
@@ -32,10 +32,7 @@ struct StringiumOptions: ParsableArguments {
     
     @Option(help: "Tell if it will generate static properties or not")
     var staticMembers: Bool = false
-
+    
-    @Option(help: "Tell if it will generate xcStrings file or not")
-    var xcStrings: Bool = false
-
     @Option(help: "Extension name. If not specified, it will generate an String extension.")
     var extensionName: String = Stringium.defaultExtensionName
     

Tests/ResgenSwiftTests/Colors/ParsedColorTests.swift

@@ -91,7 +91,7 @@ final class ParsedColorTests: XCTestCase {
         // When
         let contentJson = color.contentsJSON()
         guard let data = contentJson.data(using: .utf8),
-              let parsedJson = try? JSONSerialization.jsonObject(with: data) as? [String: Any] else {
+        let parsedJson = try? JSONSerialization.jsonObject(with: data) as? [String: Any] else {
             XCTFail("Cannot convert `contentJSON` string to Data")
             return
         }

Tests/ResgenSwiftTests/Strings/DefinitionTests.swift

@@ -100,152 +100,32 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
         /// Translation in fr :
         /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// This is a comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "This is a comment")
-        }
-        """
-        
-        let expectEn = """
-        /// Translation in en :
-        /// This is the english translation
-        ///
-        /// Comment :
-        /// This is a comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "This is a comment")
-        }
-        """
-        
-        let expectEnUs = """
-        /// Translation in en-us :
-        /// This is the english us translation
-        ///
-        /// Comment :
-        /// This is a comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "This is a comment")
-        }
-        """
-        
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    func testGeneratedNSLocalizedStringPropertyWithEmptyComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.comment = ""
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getNSLocalizedStringProperty(forLang: "fr")
-        let propertyEn = definition.getNSLocalizedStringProperty(forLang: "en")
-        let propertyEnUs = definition.getNSLocalizedStringProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-        /// Translation in fr :
-        /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// No comment
         var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "")
         }
         """
-
+        
         let expectEn = """
         /// Translation in en :
         /// This is the english translation
-        ///
-        /// Comment :
-        /// No comment
         var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "")
         }
         """
-
+        
         let expectEnUs = """
         /// Translation in en-us :
         /// This is the english us translation
-        ///
-        /// Comment :
-        /// No comment
         var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "")
         }
         """
-
+        
         XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
         XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
         XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
     }
-
+    
-    func testGeneratedNSLocalizedStringPropertyWithNoComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getNSLocalizedStringProperty(forLang: "fr")
-        let propertyEn = definition.getNSLocalizedStringProperty(forLang: "en")
-        let propertyEnUs = definition.getNSLocalizedStringProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-        /// Translation in fr :
-        /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// No comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "")
-        }
-        """
-
-        let expectEn = """
-        /// Translation in en :
-        /// This is the english translation
-        ///
-        /// Comment :
-        /// No comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "")
-        }
-        """
-
-        let expectEnUs = """
-        /// Translation in en-us :
-        /// This is the english us translation
-        ///
-        /// Comment :
-        /// No comment
-        var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "")
-        }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    // MARK: - getNSLocalizedStringStaticProperty
-
     func testGeneratedNSLocalizedStringStaticProperty() {
         // Given
         let definition = Definition(name: "definition_name")
@@ -266,150 +146,32 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
         /// Translation in fr :
         /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// This is a comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "This is a comment")
-        }
-        """
-        
-        let expectEn = """
-        /// Translation in en :
-        /// This is the english translation
-        ///
-        /// Comment :
-        /// This is a comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "This is a comment")
-        }
-        """
-        
-        let expectEnUs = """
-        /// Translation in en-us :
-        /// This is the english us translation
-        ///
-        /// Comment :
-        /// This is a comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "This is a comment")
-        }
-        """
-        
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    func testGeneratedNSLocalizedStringStaticPropertyWithEmptyComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.comment = ""
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getNSLocalizedStringStaticProperty(forLang: "fr")
-        let propertyEn = definition.getNSLocalizedStringStaticProperty(forLang: "en")
-        let propertyEnUs = definition.getNSLocalizedStringStaticProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-        /// Translation in fr :
-        /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// No comment
         static var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "")
         }
         """
-
+        
         let expectEn = """
         /// Translation in en :
         /// This is the english translation
-        ///
-        /// Comment :
-        /// No comment
         static var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "")
         }
         """
-
+        
         let expectEnUs = """
         /// Translation in en-us :
         /// This is the english us translation
-        ///
-        /// Comment :
-        /// No comment
         static var definition_name: String {
             NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "")
         }
         """
-
+        
         XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
         XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
         XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
     }
-
+    
-    func testGeneratedNSLocalizedStringStaticPropertyWithNoComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getNSLocalizedStringStaticProperty(forLang: "fr")
-        let propertyEn = definition.getNSLocalizedStringStaticProperty(forLang: "en")
-        let propertyEnUs = definition.getNSLocalizedStringStaticProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-        /// Translation in fr :
-        /// C'est la traduction francaise
-        ///
-        /// Comment :
-        /// No comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "C'est la traduction francaise", comment: "")
-        }
-        """
-
-        let expectEn = """
-        /// Translation in en :
-        /// This is the english translation
-        ///
-        /// Comment :
-        /// No comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english translation", comment: "")
-        }
-        """
-
-        let expectEnUs = """
-        /// Translation in en-us :
-        /// This is the english us translation
-        ///
-        /// Comment :
-        /// No comment
-        static var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "This is the english us translation", comment: "")
-        }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
     func testGeneratedNSLocalizedStringPropertyWithOneArgument() {
         // Given
         let definition = Definition(name: "definition_name")
@@ -426,23 +188,17 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
         /// Translation in fr :
         /// Welcome "%@" !
-        ///
-        /// Comment :
-        /// This is a comment
         var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Welcome \"%@\" !", comment: "This is a comment")
+            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Welcome \"%@\" !", comment: "")
         }
         
         /// Translation in fr :
         /// Welcome "%@" !
-        ///
-        /// Comment :
-        /// This is a comment
         func definition_name(arg0: String) -> String {
             String(format: self.definition_name, arg0)
         }
         """
-        
+    
         XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
     }
     
@@ -462,18 +218,12 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
         /// Translation in fr :
         /// Welcome "%@" ! Your age is %d :) Your weight is %f ;-)
-        ///
-        /// Comment :
-        /// This is a comment
         var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Welcome \"%@\" ! Your age is %d :) Your weight is %f ;-)", comment: "This is a comment")
+            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Welcome \"%@\" ! Your age is %d :) Your weight is %f ;-)", comment: "")
         }
         
         /// Translation in fr :
         /// Welcome "%@" ! Your age is %d :) Your weight is %f ;-)
-        ///
-        /// Comment :
-        /// This is a comment
         func definition_name(arg0: String, arg1: Int, arg2: Double) -> String {
             String(format: self.definition_name, arg0, arg1, arg2)
         }
@@ -499,18 +249,12 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
         /// Translation in fr :
         /// Vous %%: %1$@ %2$@ Age: %3$d
-        ///
-        /// Comment :
-        /// This is a comment
         var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Vous %%: %1$@ %2$@ Age: %3$d", comment: "This is a comment")
+            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "Vous %%: %1$@ %2$@ Age: %3$d", comment: "")
         }
         
         /// Translation in fr :
         /// Vous %%: %1$@ %2$@ Age: %3$d
-        ///
-        /// Comment :
-        /// This is a comment
         func definition_name(arg0: String, arg1: String, arg2: Int) -> String {
             String(format: self.definition_name, arg0, arg1, arg2)
         }
@@ -519,18 +263,12 @@ final class DefinitionTests: XCTestCase {
         let expectEn = """
         /// Translation in en :
         /// You %%: %2$@ %1$@ Age: %3$d
-        ///
-        /// Comment :
-        /// This is a comment
         var definition_name: String {
-            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "You %%: %2$@ %1$@ Age: %3$d", comment: "This is a comment")
+            NSLocalizedString("definition_name", tableName: kStringsFileName, bundle: Bundle.main, value: "You %%: %2$@ %1$@ Age: %3$d", comment: "")
         }
         
         /// Translation in en :
         /// You %%: %2$@ %1$@ Age: %3$d
-        ///
-        /// Comment :
-        /// This is a comment
         func definition_name(arg0: String, arg1: String, arg2: Int) -> String {
             String(format: self.definition_name, arg0, arg1, arg2)
         }
@@ -562,9 +300,6 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
             /// Translation in fr :
             /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// This is a comment
             var definition_name: String {
                 "C'est la traduction francaise"
             }
@@ -573,9 +308,6 @@ final class DefinitionTests: XCTestCase {
         let expectEn = """
             /// Translation in en :
             /// This is the english translation
-            ///
-            /// Comment :
-            /// This is a comment
             var definition_name: String {
                 "This is the english translation"
             }
@@ -584,9 +316,6 @@ final class DefinitionTests: XCTestCase {
         let expectEnUs = """
             /// Translation in en-us :
             /// This is the english us translation
-            ///
-            /// Comment :
-            /// This is a comment
             var definition_name: String {
                 "This is the english us translation"
             }
@@ -596,118 +325,7 @@ final class DefinitionTests: XCTestCase {
         XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
         XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
     }
-
+    
-    func testGeneratedRawPropertyWithEmptyComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.comment = ""
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getProperty(forLang: "fr")
-        let propertyEn = definition.getProperty(forLang: "en")
-        let propertyEnUs = definition.getProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-            /// Translation in fr :
-            /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "C'est la traduction francaise"
-            }
-        """
-
-        let expectEn = """
-            /// Translation in en :
-            /// This is the english translation
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "This is the english translation"
-            }
-        """
-
-        let expectEnUs = """
-            /// Translation in en-us :
-            /// This is the english us translation
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "This is the english us translation"
-            }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    func testGeneratedRawPropertyWithNoComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getProperty(forLang: "fr")
-        let propertyEn = definition.getProperty(forLang: "en")
-        let propertyEnUs = definition.getProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-            /// Translation in fr :
-            /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "C'est la traduction francaise"
-            }
-        """
-
-        let expectEn = """
-            /// Translation in en :
-            /// This is the english translation
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "This is the english translation"
-            }
-        """
-
-        let expectEnUs = """
-            /// Translation in en-us :
-            /// This is the english us translation
-            ///
-            /// Comment :
-            /// No comment
-            var definition_name: String {
-                "This is the english us translation"
-            }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    // MARK: - Raw static properties
-
     func testGeneratedRawStaticProperty() {
         // Given
         let definition = Definition(name: "definition_name")
@@ -728,9 +346,6 @@ final class DefinitionTests: XCTestCase {
         let expectFr = """
             /// Translation in fr :
             /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// This is a comment
             static var definition_name: String {
                 "C'est la traduction francaise"
             }
@@ -739,10 +354,7 @@ final class DefinitionTests: XCTestCase {
         let expectEn = """
             /// Translation in en :
             /// This is the english translation
-            ///
+                        static var definition_name: String {
-            /// Comment :
-            /// This is a comment
-            static var definition_name: String {
                 "This is the english translation"
             }
         """
@@ -750,9 +362,6 @@ final class DefinitionTests: XCTestCase {
         let expectEnUs = """
             /// Translation in en-us :
             /// This is the english us translation
-            ///
-            /// Comment :
-            /// This is a comment
             static var definition_name: String {
                 "This is the english us translation"
             }
@@ -762,113 +371,4 @@ final class DefinitionTests: XCTestCase {
         XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
         XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
     }
-
-    func testGeneratedRawStaticPropertyWithEmptyComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.comment = ""
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getStaticProperty(forLang: "fr")
-        let propertyEn = definition.getStaticProperty(forLang: "en")
-        let propertyEnUs = definition.getStaticProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-            /// Translation in fr :
-            /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "C'est la traduction francaise"
-            }
-        """
-
-        let expectEn = """
-            /// Translation in en :
-            /// This is the english translation
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "This is the english translation"
-            }
-        """
-
-        let expectEnUs = """
-            /// Translation in en-us :
-            /// This is the english us translation
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "This is the english us translation"
-            }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
-
-    func testGeneratedRawStaticPropertyWithNoComment() {
-        // Given
-        let definition = Definition(name: "definition_name")
-        definition.tags = ["ios","iosonly","notranslation"]
-        definition.translations = [
-            "fr": "C'est la traduction francaise",
-            "en": "This is the english translation",
-            "en-us": "This is the english us translation"
-        ]
-
-        // When
-        let propertyFr = definition.getStaticProperty(forLang: "fr")
-        let propertyEn = definition.getStaticProperty(forLang: "en")
-        let propertyEnUs = definition.getStaticProperty(forLang: "en-us")
-
-        // Expect
-        let expectFr = """
-            /// Translation in fr :
-            /// C'est la traduction francaise
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "C'est la traduction francaise"
-            }
-        """
-
-        let expectEn = """
-            /// Translation in en :
-            /// This is the english translation
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "This is the english translation"
-            }
-        """
-
-        let expectEnUs = """
-            /// Translation in en-us :
-            /// This is the english us translation
-            ///
-            /// Comment :
-            /// No comment
-            static var definition_name: String {
-                "This is the english us translation"
-            }
-        """
-
-        XCTAssertEqual(propertyFr.adaptForXCTest(), expectFr.adaptForXCTest())
-        XCTAssertEqual(propertyEn.adaptForXCTest(), expectEn.adaptForXCTest())
-        XCTAssertEqual(propertyEnUs.adaptForXCTest(), expectEnUs.adaptForXCTest())
-    }
 }