openium/consentium.droid
0
0
Fork 0
Code Pull Requests Releases Activity

feat(CON-174-175-176) : Mise en place du squelette de l’application #2

Merged
l.zborowski merged 1 commits from CON-176 into develop 2024-12-11 15:23:42 +01:00
Conversation 2 Commits 1 Files Changed 13 +249 -6
l.zborowski commented 2024-12-10 17:41:00 +01:00
Owner
Copy Link
No description provided.
l.zborowski added 1 commit 2024-12-10 17:41:01 +01:00
l.legrand requested changes 2024-12-10 17:48:48 +01:00
app/build.gradle.kts Outdated
@ -96,9 +100,15 @@ dependencies {
// Timber
implementation(libs.timber)
implementation(libs.androidx.navigation.compose)
l.legrand commented 2024-12-10 17:43:46 +01:00
Owner
Copy Link

Petit commentaire pour garder le fichier en ordre ?

Petit commentaire pour garder le fichier en ordre ?
l.zborowski marked this conversation as resolved
app/build.gradle.kts Outdated
@ -102,2 +109,4 @@
androidTestImplementation(libs.test.espresso)
androidTestImplementation(libs.test.androidx.junit)
implementation(libs.kotlin.serialization)
l.legrand commented 2024-12-10 17:44:13 +01:00
Owner
Copy Link

Idem essaie de garder les fichiers gradle / toml en ordre.

Idem essaie de garder les fichiers gradle / toml en ordre.
l.zborowski marked this conversation as resolved
app/src/main/java/fr/openium/consentium/ui/navigation/Destination.kt Outdated
@ -0,0 +5,4 @@
sealed interface Destination {
@kotlinx.serialization.Serializable
l.legrand commented 2024-12-10 17:45:06 +01:00
Owner
Copy Link

Pas la bonne annotation.

Pas la bonne annotation.
l.zborowski marked this conversation as resolved
app/src/main/java/fr/openium/consentium/ui/screens/splash/SplashScreen.kt Outdated
@ -0,0 +43,4 @@
navigateToMain()
}
l.legrand commented 2024-12-10 17:45:33 +01:00
Owner
Copy Link

Il y a beaucoup d'espace ici non ?

Il y a beaucoup d'espace ici non ?
l.zborowski marked this conversation as resolved
app/src/main/java/fr/openium/consentium/ui/screens/splash/SplashScreenViewModel.kt Outdated
@ -0,0 +14,4 @@
) : ViewModel() {
private val _state = MutableStateFlow<State>(State.Loading)
val state: StateFlow<State> = _state
l.legrand commented 2024-12-10 17:45:57 +01:00
Owner
Copy Link

_state.asStateFlow()

_state.asStateFlow()
l.zborowski marked this conversation as resolved
app/src/main/java/fr/openium/consentium/ui/screens/splash/SplashScreenViewModel.kt Outdated
@ -0,0 +37,4 @@
}
init {
loadMain()
l.legrand commented 2024-12-10 17:47:03 +01:00
Owner
Copy Link

On ne met pas de tache qui prennent du temps dans les init.

Ici, ce n'est pas grave, mais c'est pour info.

On ne met pas de tache qui prennent du temps dans les init. Ici, ce n'est pas grave, mais c'est pour info.
l.zborowski marked this conversation as resolved
build.gradle.kts Outdated
@ -14,4 +14,10 @@ plugins {
// Agp
alias(libs.plugins.android.library) apply false
l.legrand commented 2024-12-10 17:47:11 +01:00
Owner
Copy Link

Commentaire

Commentaire
l.zborowski marked this conversation as resolved
build.gradle.kts Outdated
@ -16,1 +16,4 @@
alias(libs.plugins.android.library) apply false
alias(libs.plugins.hilt) apply false
l.legrand commented 2024-12-10 17:47:16 +01:00
Owner
Copy Link

Commentaire

Commentaire
l.zborowski marked this conversation as resolved
gradle/libs.versions.toml Outdated
@ -40,0 +45,4 @@
navigationCommonKtx = "2.8.2"
navigationRuntimeKtx = "2.8.2"
navigationCompose = "2.8.2"
l.legrand commented 2024-12-10 17:48:21 +01:00
Owner
Copy Link

Les trois versions sont les mêmes, la référence n'est pas censée être la même pour chaque lib ?

  • commentaire
Les trois versions sont les mêmes, la référence n'est pas censée être la même pour chaque lib ? + commentaire
l.zborowski marked this conversation as resolved
gradle/libs.versions.toml Outdated
@ -69,1 +81,4 @@
# Matomo
matomo = { module = "com.github.matomo-org:matomo-sdk-android", version.ref = "matomo" }
l.legrand commented 2024-12-10 17:48:36 +01:00
Owner
Copy Link

Commenaire

Commenaire
l.zborowski marked this conversation as resolved
l.zborowski changed title from mise en place du squelette de l'application to eat(CON-174-175-176) : Mise en place du squelette de l’application 2024-12-10 17:57:29 +01:00
l.zborowski changed title from eat(CON-174-175-176) : Mise en place du squelette de l’application to feat(CON-174-175-176) : Mise en place du squelette de l’application 2024-12-10 17:57:34 +01:00
l.zborowski commented 2024-12-10 17:58:58 +01:00
Author
Owner
Copy Link

ticket :

https://youtrack.openium.fr/agiles/105-280/106-1288?issue=CON-174
https://youtrack.openium.fr/agiles/105-280/106-1288?issue=CON-175
https://youtrack.openium.fr/agiles/105-280/106-1288?issue=CON-176

ticket : https://youtrack.openium.fr/agiles/105-280/106-1288?issue=CON-174 https://youtrack.openium.fr/agiles/105-280/106-1288?issue=CON-175 https://youtrack.openium.fr/agiles/105-280/106-1288?issue=CON-176
l.zborowski added 1 commit 2024-12-11 14:52:15 +01:00
l.zborowski force-pushed CON-176 from 9df89f1548 to 89279c0a0a 2024-12-11 14:54:30 +01:00 Compare
l.zborowski force-pushed CON-176 from 89279c0a0a to 5be4981eb2 2024-12-11 15:22:55 +01:00 Compare
l.zborowski merged commit 2b9bfe3c5b into develop 2024-12-11 15:23:42 +01:00
l.zborowski deleted branch CON-176 2024-12-13 08:56:02 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
l.legrand
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
a.chabozy a.valin a.vallet b.lambert c.guelle c.samson c.villeneuve e.berlinet e.guilbault e.joly g.fernandes h.peytavin j.neboit jenkins k.renella l.adlington l.godart l.legrand l.perret l.riviere l.seguin l.zborowski m.daim n.chaduc o.coudert o.goutet p.hurdebourcq q.bandera r.bergoin r.bossin s.mellouk s.tabaka t.coulange t.leduc t.schmitt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openium/consentium.droid#2
No description provided.
Delete Branch "CON-176"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?