From 3ffd1904061da46625ec1650ead04051cd570ba7 Mon Sep 17 00:00:00 2001 From: Louis Legrand Date: Thu, 20 Feb 2025 12:00:36 +0100 Subject: [PATCH] =?UTF-8?q?feat(CON-285)=20:=20Respecter=20les=20crit?= =?UTF-8?q?=C3=A8res=20d'accessibilit=C3=A9=20sur=20les=20boutons=20des=20?= =?UTF-8?q?=C3=A9crans=20utilisateurs.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../ui/components/ConsentiumUIDetailConsentComponent.kt | 2 +- .../ui/components/ConsentiumUIGeneralConsentComponent.kt | 2 +- .../consentium_ui/ui/components/core/PurposeComponent.kt | 6 ++++++ .../ui/components/core/toggle/ConsentiumUISwitch.kt | 2 ++ consentium-ui/src/main/res/values-fr/strings.xml | 2 ++ consentium-ui/src/main/res/values/strings.xml | 2 ++ 6 files changed, 14 insertions(+), 2 deletions(-) diff --git a/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/ConsentiumUIDetailConsentComponent.kt b/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/ConsentiumUIDetailConsentComponent.kt index 9e1dd10..0608c65 100644 --- a/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/ConsentiumUIDetailConsentComponent.kt +++ b/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/ConsentiumUIDetailConsentComponent.kt @@ -55,7 +55,7 @@ internal fun ConsentiumUIDetailConsentComponent( IconButton(onClick = { onNavigateBack() }) { Icon( imageVector = Icons.AutoMirrored.Filled.ArrowBack, - contentDescription = "Back", + contentDescription = stringResource(R.string.back), tint = ConsentiumUITheme.colors.onSurface, modifier = Modifier.size(26.dp), ) diff --git a/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/ConsentiumUIGeneralConsentComponent.kt b/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/ConsentiumUIGeneralConsentComponent.kt index b3d5b91..a3e329d 100644 --- a/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/ConsentiumUIGeneralConsentComponent.kt +++ b/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/ConsentiumUIGeneralConsentComponent.kt @@ -51,7 +51,7 @@ internal fun ConsentiumUIGeneralConsentComponent( AsyncImage( modifier = Modifier.heightIn(min = 48.dp), model = generalConsentUI.iconUrl, - contentDescription = "Image", + contentDescription = stringResource(R.string.app_icon), contentScale = ContentScale.FillBounds, ) } diff --git a/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/core/PurposeComponent.kt b/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/core/PurposeComponent.kt index 23a4aa3..5c9310e 100644 --- a/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/core/PurposeComponent.kt +++ b/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/core/PurposeComponent.kt @@ -14,6 +14,8 @@ import androidx.compose.runtime.setValue import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier import androidx.compose.ui.res.stringResource +import androidx.compose.ui.semantics.contentDescription +import androidx.compose.ui.semantics.semantics import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.unit.dp import fr.openium.consentium_ui.R @@ -63,6 +65,10 @@ internal fun PurposeComponent( vendorUI.isAccepted = isChecked } }, + modifier = Modifier + .semantics { + contentDescription = purposeUI.title + } ) } diff --git a/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/core/toggle/ConsentiumUISwitch.kt b/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/core/toggle/ConsentiumUISwitch.kt index eabc223..dc4be1f 100644 --- a/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/core/toggle/ConsentiumUISwitch.kt +++ b/consentium-ui/src/main/java/fr/openium/consentium_ui/ui/components/core/toggle/ConsentiumUISwitch.kt @@ -15,6 +15,7 @@ import fr.openium.consentium_ui.ui.components.style.ConsentiumUITheme internal fun ConsentiumUISwitch( checked: Boolean, onCheckedChange: (Boolean) -> Unit, + modifier: Modifier = Modifier, ) { Switch( checked = checked, @@ -22,6 +23,7 @@ internal fun ConsentiumUISwitch( colors = SwitchDefaults.colors( checkedTrackColor = ConsentiumUITheme.colors.secondary, ), + modifier = modifier, ) } diff --git a/consentium-ui/src/main/res/values-fr/strings.xml b/consentium-ui/src/main/res/values-fr/strings.xml index 79a7001..e01fa2e 100644 --- a/consentium-ui/src/main/res/values-fr/strings.xml +++ b/consentium-ui/src/main/res/values-fr/strings.xml @@ -1,5 +1,7 @@ + Icone de l\'application + Retour Politique de cookies Accepter et fermer Continuer sans accepter diff --git a/consentium-ui/src/main/res/values/strings.xml b/consentium-ui/src/main/res/values/strings.xml index ea3f340..c535c47 100644 --- a/consentium-ui/src/main/res/values/strings.xml +++ b/consentium-ui/src/main/res/values/strings.xml @@ -1,5 +1,7 @@ + Application icon + Back Cookie policy Accept and close Continue without accepting